You are viewing a plain text version of this content. The canonical link for it is here.

Posted to xindice-dev@xml.apache.org by db...@qis.net on 2004/07/13 21:31:38 UTC

Patch to fix silly String usage

This patch fixes
(1) Stupid use of new String( "xxx" ) constructor
    -> just use "xxx"
(2) Comparing strings using == instead of .equals
(3) A possible Null Pointer exception with strings.

Re: Patch to fix silly String usage

Posted by Vadim Gritsenko <va...@reverycodes.com>.

dbrosius@qis.net wrote:

>ACK! File not saved.
>Trying again. Use this patch file
>  
>

Applied, with minor mods. Thanks.

Vadim


>Quoting dbrosius@qis.net:
>
>  
>
>>This patch fixes
>>(1) Stupid use of new String( "xxx" ) constructor
>>    -> just use "xxx"
>>(2) Comparing strings using == instead of .equals
>>(3) A possible Null Pointer exception with strings.
>>

Re: Patch to fix silly String usage

Posted by Vadim Gritsenko <va...@reverycodes.com>.

dbrosius@qis.net wrote:

>ACK! File not saved.
>Trying again. Use this patch file
>  
>

Thanks for the patch. It can take some time for me to review your patch, 
so please be patient.

Vadim



>Quoting dbrosius@qis.net:
>
>  
>
>>This patch fixes
>>(1) Stupid use of new String( "xxx" ) constructor
>>    -> just use "xxx"
>>(2) Comparing strings using == instead of .equals
>>(3) A possible Null Pointer exception with strings.
>>
>>    
>>
>
>
>  
>

Re: Patch to fix silly String usage

Posted by db...@qis.net.

ACK! File not saved.
Trying again. Use this patch file

Quoting dbrosius@qis.net:

> 
> This patch fixes
> (1) Stupid use of new String( "xxx" ) constructor
>     -> just use "xxx"
> (2) Comparing strings using == instead of .equals
> (3) A possible Null Pointer exception with strings.
>