You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "KeDeng (Code Review)" <ge...@cloudera.org> on 2022/07/29 04:02:47 UTC
[kudu-CR] [tool] Add gflag to control the display of hash info when show partition info.
KeDeng has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18797
Change subject: [tool] Add gflag to control the display of hash info when show partition info.
......................................................................
[tool] Add gflag to control the display of hash info when show partition info.
The command with 'show_hash_partition_info' looks like:
`kudu table list --list_tablets --show_tablet_partition_info --show_hash_partition_info <table_name> <master_addresses> [-negotiation_timeout_ms=<ms>] [-timeout_ms=<ms>]`
The output of the command with 'show_hash_partition_info' looks like:
`
TestTableListPartition
T f7537632388b46a394b818979a17920c : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 0, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 4f1a71d9907b49a1aff479fbafc65a42 : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 0, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T b11db1b8fc304cc19a0211df45818efc : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 1, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T db401470d3374d9bba75f56677c1d1c2 : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 1, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T ead7e1bbc3cd465cb755118e769b8c72 : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 2, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 19ffc549b26f49928ecb552224860bf2 : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 2, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 38c95bd395404dbda094826f5054aced : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 0, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 8c257d4c5ebc4bffb5c27beeef1e9355 : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 0, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 6c6d1f1e4df8456f9853beaab6bd7bee : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 1, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 05f27b37443c4b7e843e1d7bba2fb5ee : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 1, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 48ece2705bc14819b1a38aa489f39e50 : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 2, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 768cea86cf8543258313e242afa8f057 : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 2, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
`
The command without 'show_hash_partition_info' looks like:
`kudu table list --list_tablets --show_tablet_partition_info <table_name> <master_addresses> [-negotiation_timeout_ms=<ms>] [-timeout_ms=<ms>]`
The output of the command without 'show_hash_partition_info' looks like:
`
TestTableListPartition
T f7537632388b46a394b818979a17920c : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 4f1a71d9907b49a1aff479fbafc65a42 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T b11db1b8fc304cc19a0211df45818efc : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T db401470d3374d9bba75f56677c1d1c2 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T ead7e1bbc3cd465cb755118e769b8c72 : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 19ffc549b26f49928ecb552224860bf2 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 38c95bd395404dbda094826f5054aced : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 8c257d4c5ebc4bffb5c27beeef1e9355 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 6c6d1f1e4df8456f9853beaab6bd7bee : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 05f27b37443c4b7e843e1d7bba2fb5ee : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 48ece2705bc14819b1a38aa489f39e50 : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 768cea86cf8543258313e242afa8f057 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
`
Change-Id: I8bba23740a8544ea40360b70e394c31d500f81c1
---
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_table.cc
5 files changed, 117 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/18797/1
--
To view, visit http://gerrit.cloudera.org:8080/18797
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8bba23740a8544ea40360b70e394c31d500f81c1
Gerrit-Change-Number: 18797
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
[kudu-CR] [tool] Add gflag to control the display of hash info when show partition info.
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18797 )
Change subject: [tool] Add gflag to control the display of hash info when show partition info.
......................................................................
Patch Set 3:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/common/partition-test.cc
File src/kudu/common/partition-test.cc:
http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/common/partition-test.cc@576
PS2, Line 576: EXPECT_EQ("HASH (a) PARTITION 0, HASH (b) PARTITION 0, "
: R"(RANGE (a, b, c) PARTITION VALUES < ("a1", "b1", "c1"))",
: partition_schema.PartitionDebugString(partitions[0], schema));
> nit: is there any specific reason not testing the output without hash parti
I just want to make sure that the output is correct without hash partition. Because I have seen the tests of these scenarios, it may be better to add these tests.
http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/common/partition.h
File src/kudu/common/partition.h:
http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/common/partition.h@390
PS2, Line 390:
> Could you please introduce a enumeration with names that reflect the essenc
Done
http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/common/partition.h@390
PS2, Line 390:
> Could you please introduce a enumeration with names that reflect the essenc
Done
http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:
http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/tools/kudu-admin-test.cc@2211
PS2, Line 2211: delta_tablet_ids.push_back(tablet_id);
> Maybe, create a lambda parameterized by the show_hash_partition_info and ca
Done
http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/tools/kudu-admin-test.cc@2233
PS2, Line 2233:
> nit: wrong indent
Done
http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/tools/kudu-admin-test.cc@2270
PS2, Line 2270:
> nit: wrong indent
Done
--
To view, visit http://gerrit.cloudera.org:8080/18797
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bba23740a8544ea40360b70e394c31d500f81c1
Gerrit-Change-Number: 18797
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 01 Aug 2022 06:47:13 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tool] Add gflag to control the display of hash info when show partition info.
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18797
to look at the new patch set (#3).
Change subject: [tool] Add gflag to control the display of hash info when show partition info.
......................................................................
[tool] Add gflag to control the display of hash info when show partition info.
The command with 'show_hash_partition_info' looks like:
`kudu table list --list_tablets --show_tablet_partition_info --show_hash_partition_info <table_name> <master_addresses> [-negotiation_timeout_ms=<ms>] [-timeout_ms=<ms>]`
The output of the command with 'show_hash_partition_info' looks like:
`
TestTableListPartition
T f7537632388b46a394b818979a17920c : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 0, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 4f1a71d9907b49a1aff479fbafc65a42 : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 0, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T b11db1b8fc304cc19a0211df45818efc : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 1, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T db401470d3374d9bba75f56677c1d1c2 : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 1, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T ead7e1bbc3cd465cb755118e769b8c72 : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 2, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 19ffc549b26f49928ecb552224860bf2 : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 2, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 38c95bd395404dbda094826f5054aced : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 0, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 8c257d4c5ebc4bffb5c27beeef1e9355 : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 0, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 6c6d1f1e4df8456f9853beaab6bd7bee : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 1, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 05f27b37443c4b7e843e1d7bba2fb5ee : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 1, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 48ece2705bc14819b1a38aa489f39e50 : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 2, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 768cea86cf8543258313e242afa8f057 : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 2, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
`
The command without 'show_hash_partition_info' looks like:
`kudu table list --list_tablets --show_tablet_partition_info <table_name> <master_addresses> [-negotiation_timeout_ms=<ms>] [-timeout_ms=<ms>]`
The output of the command without 'show_hash_partition_info' looks like:
`
TestTableListPartition
T f7537632388b46a394b818979a17920c : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 4f1a71d9907b49a1aff479fbafc65a42 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T b11db1b8fc304cc19a0211df45818efc : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T db401470d3374d9bba75f56677c1d1c2 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T ead7e1bbc3cd465cb755118e769b8c72 : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 19ffc549b26f49928ecb552224860bf2 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 38c95bd395404dbda094826f5054aced : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 8c257d4c5ebc4bffb5c27beeef1e9355 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 6c6d1f1e4df8456f9853beaab6bd7bee : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 05f27b37443c4b7e843e1d7bba2fb5ee : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 48ece2705bc14819b1a38aa489f39e50 : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 768cea86cf8543258313e242afa8f057 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
`
Change-Id: I8bba23740a8544ea40360b70e394c31d500f81c1
---
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_table.cc
5 files changed, 84 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/18797/3
--
To view, visit http://gerrit.cloudera.org:8080/18797
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8bba23740a8544ea40360b70e394c31d500f81c1
Gerrit-Change-Number: 18797
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tool] Add gflag to control the display of hash info when show partition info.
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18797 )
Change subject: [tool] Add gflag to control the display of hash info when show partition info.
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18797
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bba23740a8544ea40360b70e394c31d500f81c1
Gerrit-Change-Number: 18797
Gerrit-PatchSet: 4
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Tue, 02 Aug 2022 02:36:23 +0000
Gerrit-HasComments: No
[kudu-CR] [tool] Add gflag to control the display of hash info when show partition info.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18797 )
Change subject: [tool] Add gflag to control the display of hash info when show partition info.
......................................................................
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/common/partition-test.cc
File src/kudu/common/partition-test.cc:
http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/common/partition-test.cc@576
PS2, Line 576: EXPECT_EQ("HASH (a) PARTITION 0, HASH (b) PARTITION 0, "
: R"(RANGE (a, b, c) PARTITION VALUES < ("a1", "b1", "c1"))",
: partition_schema.PartitionDebugString(partitions[0], schema));
nit: is there any specific reason not testing the output without hash partition info here?
http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/common/partition.h
File src/kudu/common/partition.h:
http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/common/partition.h@390
PS2, Line 390: bool
Could you please introduce a enumeration with names that reflect the essence of the change in behavior instead of just boolean parameter, please? It would help with code readability. For example:
enum HashPartitionInfo {
HIDE = 0,
SHOW = 1,
};
Then calling this method in C++11 code would be something
auto partition_str = partition_schema.PartitionDebugString(
partition,
schema,
HashPartitionInfo::HIDE);
auto partition_str = partition_schema.PartitionDebugString(
partition,
schema,
false);
http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:
http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/tools/kudu-admin-test.cc@2211
PS2, Line 2211: {
Maybe, create a lambda parameterized by the show_hash_partition_info and call it with true/false argument instead of duplicating the code?
http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/tools/kudu-admin-test.cc@2233
PS2, Line 2233:
nit: wrong indent
http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/tools/kudu-admin-test.cc@2270
PS2, Line 2270:
nit: wrong indent
--
To view, visit http://gerrit.cloudera.org:8080/18797
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bba23740a8544ea40360b70e394c31d500f81c1
Gerrit-Change-Number: 18797
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 29 Jul 2022 18:17:15 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tool] Add gflag to control the display of hash info when show partition info.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18797 )
Change subject: [tool] Add gflag to control the display of hash info when show partition info.
......................................................................
[tool] Add gflag to control the display of hash info when show partition info.
The command with 'show_hash_partition_info' looks like:
`kudu table list --list_tablets --show_tablet_partition_info --show_hash_partition_info <table_name> <master_addresses> [-negotiation_timeout_ms=<ms>] [-timeout_ms=<ms>]`
The output of the command with 'show_hash_partition_info' looks like:
`
TestTableListPartition
T f7537632388b46a394b818979a17920c : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 0, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 4f1a71d9907b49a1aff479fbafc65a42 : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 0, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T b11db1b8fc304cc19a0211df45818efc : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 1, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T db401470d3374d9bba75f56677c1d1c2 : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 1, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T ead7e1bbc3cd465cb755118e769b8c72 : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 2, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 19ffc549b26f49928ecb552224860bf2 : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 2, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 38c95bd395404dbda094826f5054aced : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 0, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 8c257d4c5ebc4bffb5c27beeef1e9355 : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 0, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 6c6d1f1e4df8456f9853beaab6bd7bee : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 1, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 05f27b37443c4b7e843e1d7bba2fb5ee : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 1, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 48ece2705bc14819b1a38aa489f39e50 : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 2, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 768cea86cf8543258313e242afa8f057 : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 2, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
`
The command without 'show_hash_partition_info' looks like:
`kudu table list --list_tablets --show_tablet_partition_info <table_name> <master_addresses> [-negotiation_timeout_ms=<ms>] [-timeout_ms=<ms>]`
The output of the command without 'show_hash_partition_info' looks like:
`
TestTableListPartition
T f7537632388b46a394b818979a17920c : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 4f1a71d9907b49a1aff479fbafc65a42 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T b11db1b8fc304cc19a0211df45818efc : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T db401470d3374d9bba75f56677c1d1c2 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T ead7e1bbc3cd465cb755118e769b8c72 : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 19ffc549b26f49928ecb552224860bf2 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 38c95bd395404dbda094826f5054aced : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 8c257d4c5ebc4bffb5c27beeef1e9355 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 6c6d1f1e4df8456f9853beaab6bd7bee : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 05f27b37443c4b7e843e1d7bba2fb5ee : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 48ece2705bc14819b1a38aa489f39e50 : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 768cea86cf8543258313e242afa8f057 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
`
Change-Id: I8bba23740a8544ea40360b70e394c31d500f81c1
Reviewed-on: http://gerrit.cloudera.org:8080/18797
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <ac...@gmail.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_table.cc
5 files changed, 84 insertions(+), 13 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yingchun Lai: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18797
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8bba23740a8544ea40360b70e394c31d500f81c1
Gerrit-Change-Number: 18797
Gerrit-PatchSet: 5
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [tool] Add gflag to control the display of hash info when show partition info.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18797 )
Change subject: [tool] Add gflag to control the display of hash info when show partition info.
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/common/partition-test.cc
File src/kudu/common/partition-test.cc:
http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/common/partition-test.cc@576
PS2, Line 576: EXPECT_EQ("HASH (a) PARTITION 0, HASH (b) PARTITION 0, "
: R"(RANGE (a, b, c) PARTITION VALUES < ("a1", "b1", "c1"))",
: partition_schema.PartitionDebugString(partitions[0], schema));
> I just want to make sure that the output is correct without hash partition.
I was curious whether these particular lines were substantially different from the others where you added tests for the output of PartitionDebugString(). OK, I guess that's enough to have just the rest of partitions covered since it's a lot of coverage already.
http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/common/partition.h
File src/kudu/common/partition.h:
http://gerrit.cloudera.org:8080/#/c/18797/2/src/kudu/common/partition.h@390
PS2, Line 390:
> Done
Thank you!
--
To view, visit http://gerrit.cloudera.org:8080/18797
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bba23740a8544ea40360b70e394c31d500f81c1
Gerrit-Change-Number: 18797
Gerrit-PatchSet: 4
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Wed, 03 Aug 2022 04:36:01 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tool] Add gflag to control the display of hash info when show partition info.
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18797
to look at the new patch set (#4).
Change subject: [tool] Add gflag to control the display of hash info when show partition info.
......................................................................
[tool] Add gflag to control the display of hash info when show partition info.
The command with 'show_hash_partition_info' looks like:
`kudu table list --list_tablets --show_tablet_partition_info --show_hash_partition_info <table_name> <master_addresses> [-negotiation_timeout_ms=<ms>] [-timeout_ms=<ms>]`
The output of the command with 'show_hash_partition_info' looks like:
`
TestTableListPartition
T f7537632388b46a394b818979a17920c : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 0, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 4f1a71d9907b49a1aff479fbafc65a42 : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 0, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T b11db1b8fc304cc19a0211df45818efc : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 1, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T db401470d3374d9bba75f56677c1d1c2 : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 1, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T ead7e1bbc3cd465cb755118e769b8c72 : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 2, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 19ffc549b26f49928ecb552224860bf2 : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 2, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 38c95bd395404dbda094826f5054aced : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 0, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 8c257d4c5ebc4bffb5c27beeef1e9355 : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 0, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 6c6d1f1e4df8456f9853beaab6bd7bee : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 1, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 05f27b37443c4b7e843e1d7bba2fb5ee : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 1, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 48ece2705bc14819b1a38aa489f39e50 : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 2, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 768cea86cf8543258313e242afa8f057 : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 2, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
`
The command without 'show_hash_partition_info' looks like:
`kudu table list --list_tablets --show_tablet_partition_info <table_name> <master_addresses> [-negotiation_timeout_ms=<ms>] [-timeout_ms=<ms>]`
The output of the command without 'show_hash_partition_info' looks like:
`
TestTableListPartition
T f7537632388b46a394b818979a17920c : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 4f1a71d9907b49a1aff479fbafc65a42 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T b11db1b8fc304cc19a0211df45818efc : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T db401470d3374d9bba75f56677c1d1c2 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T ead7e1bbc3cd465cb755118e769b8c72 : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 19ffc549b26f49928ecb552224860bf2 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 38c95bd395404dbda094826f5054aced : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 8c257d4c5ebc4bffb5c27beeef1e9355 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 6c6d1f1e4df8456f9853beaab6bd7bee : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 05f27b37443c4b7e843e1d7bba2fb5ee : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 48ece2705bc14819b1a38aa489f39e50 : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 768cea86cf8543258313e242afa8f057 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
`
Change-Id: I8bba23740a8544ea40360b70e394c31d500f81c1
---
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_table.cc
5 files changed, 84 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/18797/4
--
To view, visit http://gerrit.cloudera.org:8080/18797
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8bba23740a8544ea40360b70e394c31d500f81c1
Gerrit-Change-Number: 18797
Gerrit-PatchSet: 4
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tool] Add gflag to control the display of hash info when show partition info.
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18797
to look at the new patch set (#2).
Change subject: [tool] Add gflag to control the display of hash info when show partition info.
......................................................................
[tool] Add gflag to control the display of hash info when show partition info.
The command with 'show_hash_partition_info' looks like:
`kudu table list --list_tablets --show_tablet_partition_info --show_hash_partition_info <table_name> <master_addresses> [-negotiation_timeout_ms=<ms>] [-timeout_ms=<ms>]`
The output of the command with 'show_hash_partition_info' looks like:
`
TestTableListPartition
T f7537632388b46a394b818979a17920c : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 0, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 4f1a71d9907b49a1aff479fbafc65a42 : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 0, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T b11db1b8fc304cc19a0211df45818efc : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 1, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T db401470d3374d9bba75f56677c1d1c2 : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 1, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T ead7e1bbc3cd465cb755118e769b8c72 : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 2, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 19ffc549b26f49928ecb552224860bf2 : HASH (key_hash0) PARTITION 0, HASH (key_hash1, key_hash2) PARTITION 2, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 38c95bd395404dbda094826f5054aced : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 0, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 8c257d4c5ebc4bffb5c27beeef1e9355 : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 0, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 6c6d1f1e4df8456f9853beaab6bd7bee : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 1, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 05f27b37443c4b7e843e1d7bba2fb5ee : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 1, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 48ece2705bc14819b1a38aa489f39e50 : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 2, RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 768cea86cf8543258313e242afa8f057 : HASH (key_hash0) PARTITION 1, HASH (key_hash1, key_hash2) PARTITION 2, RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
`
The command without 'show_hash_partition_info' looks like:
`kudu table list --list_tablets --show_tablet_partition_info <table_name> <master_addresses> [-negotiation_timeout_ms=<ms>] [-timeout_ms=<ms>]`
The output of the command without 'show_hash_partition_info' looks like:
`
TestTableListPartition
T f7537632388b46a394b818979a17920c : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 4f1a71d9907b49a1aff479fbafc65a42 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T b11db1b8fc304cc19a0211df45818efc : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T db401470d3374d9bba75f56677c1d1c2 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T ead7e1bbc3cd465cb755118e769b8c72 : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 19ffc549b26f49928ecb552224860bf2 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 38c95bd395404dbda094826f5054aced : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 8c257d4c5ebc4bffb5c27beeef1e9355 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 6c6d1f1e4df8456f9853beaab6bd7bee : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 05f27b37443c4b7e843e1d7bba2fb5ee : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 48ece2705bc14819b1a38aa489f39e50 : RANGE (key_range) PARTITION 0 <= VALUES < 1
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
T 768cea86cf8543258313e242afa8f057 : RANGE (key_range) PARTITION 2 <= VALUES < 3
L 883ba129547f4e9a90134fac739334f1 127.18.13.1:34907
`
Change-Id: I8bba23740a8544ea40360b70e394c31d500f81c1
---
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_table.cc
5 files changed, 117 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/18797/2
--
To view, visit http://gerrit.cloudera.org:8080/18797
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8bba23740a8544ea40360b70e394c31d500f81c1
Gerrit-Change-Number: 18797
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)