You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/05/04 12:26:27 UTC
[GitHub] nvazquez commented on a change in pull request #2615: config-drive:
support user data on L2 networks
nvazquez commented on a change in pull request #2615: config-drive: support user data on L2 networks
URL: https://github.com/apache/cloudstack/pull/2615#discussion_r186066103
##########
File path: ui/scripts/configuration.js
##########
@@ -2415,7 +2415,7 @@
$supportedServices.css('display', 'inline-block');
} else if ($guestTypeField.val() == 'L2') {
$useVpc.hide();
- $supportedServices.hide();
+ $supportedServices.css('display', 'inline-block');
Review comment:
@rhtyd what if we display a checkbox with label 'User data (ConfigDrive)'? If it is checked, we can set serviceProviderList parameter to ConfigDrive and if not we'll pass it blank. This way we avoid user selecting unsupported services from the UI. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services