[GitHub] [couchdb] nickva commented on a diff in pull request #4569: feat(`mango`): add `keys_examined` for `execution_stats`

["nickva (via GitHub)" <gi...@apache.org>]

nickva commented on code in PR #4569:
URL: https://github.com/apache/couchdb/pull/4569#discussion_r1186234859


##########
src/mango/src/mango_cursor_view.erl:
##########
@@ -384,9 +409,15 @@ view_cb({row, Row}, #mrargs{extra = Options} = Acc) ->
             Process(Doc)
     end,
     {ok, Acc};
-view_cb(complete, Acc) ->
+view_cb(complete, #mrargs{extra = Options} = Acc) ->
+    case couch_util:get_value(execution_stats_map, Options) of

Review Comment:
   It look a bit cleaner to have a default `false` value and then explicitly match on `true` or `false`. What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org