You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Adrien Grand (JIRA)" <ji...@apache.org> on 2012/12/01 23:45:58 UTC
[jira] [Created] (LUCENE-4584) Compare the LZ4 implementation in
Lucene against the original impl
Adrien Grand created LUCENE-4584:
------------------------------------
Summary: Compare the LZ4 implementation in Lucene against the original impl
Key: LUCENE-4584
URL: https://issues.apache.org/jira/browse/LUCENE-4584
Project: Lucene - Core
Issue Type: Task
Reporter: Adrien Grand
Assignee: Adrien Grand
Priority: Blocker
Fix For: 4.1
We should add tests to make sure that the LZ4 impl in Lucene compresses data the exact same way as the original impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4584) Compare the LZ4 implementation in
Lucene against the original impl
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508106#comment-13508106 ]
Uwe Schindler commented on LUCENE-4584:
---------------------------------------
Adrien: good idea.
Steven: We are a Java project and we have no platform independent way to run C code. I think Adrien's idea is enough, maybe use 2 or 3 different length examples. Just like Apache TIKA parading MS Office docs, they also don't start MS Office while testing ♥
> Compare the LZ4 implementation in Lucene against the original impl
> ------------------------------------------------------------------
>
> Key: LUCENE-4584
> URL: https://issues.apache.org/jira/browse/LUCENE-4584
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Blocker
> Fix For: 4.1
>
>
> We should add tests to make sure that the LZ4 impl in Lucene compresses data the exact same way as the original impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4584) Compare the LZ4 implementation in
Lucene against the original impl
Posted by "Adrien Grand (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508276#comment-13508276 ]
Adrien Grand commented on LUCENE-4584:
--------------------------------------
bq. I only care that it compresses well, is reasonably fast, and doesn't corrupt.
Right, the issue is probably badly named. The reason why I want to compare against the original impl is exacly for the reasons you mention: making sure that our impl compresses well and trying to find bugs in it.
> Compare the LZ4 implementation in Lucene against the original impl
> ------------------------------------------------------------------
>
> Key: LUCENE-4584
> URL: https://issues.apache.org/jira/browse/LUCENE-4584
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Fix For: 4.1
>
>
> We should add tests to make sure that the LZ4 impl in Lucene compresses data the exact same way as the original impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4584) Compare the LZ4 implementation in
Lucene against the original impl
Posted by "Adrien Grand (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508110#comment-13508110 ]
Adrien Grand commented on LUCENE-4584:
--------------------------------------
Testing cross-implementation compression/decompression would indeed be very cool but I'm a little worried about adding the sources of LZ4 and a task to compile C code to the lucene-core build (or maybe I could do these LZ4 tests in a dedicated module so that it doesn't make lucene-core depend on native code?).
I think we should also compare the output bytes to make sure the compressor is efficient (a perfectly valid LZ4 implementation would be to always write a single sequence that only contains the input bytes as literals, this is what should happen only when the input is incompressible). Given that the LZ4 output depends on the endianess of the machine, this can unfortunately only be done with static files.
> Compare the LZ4 implementation in Lucene against the original impl
> ------------------------------------------------------------------
>
> Key: LUCENE-4584
> URL: https://issues.apache.org/jira/browse/LUCENE-4584
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Blocker
> Fix For: 4.1
>
>
> We should add tests to make sure that the LZ4 impl in Lucene compresses data the exact same way as the original impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4584) Compare the LZ4 implementation in
Lucene against the original impl
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508292#comment-13508292 ]
Uwe Schindler commented on LUCENE-4584:
---------------------------------------
I agree with Robert here. We don't need to test random data, for Lucene only 2 things are important:
- When you compress random data and decompress it again, the same exact bytes must come back. This should be tested and needs no external C code. This is the doesn't corrumpt™ Robert is talking about.
- The compressed content should never get significantly bigger
There is no reason at all that Lucene's LZ4 returns the same compressed output. E.g. if we find a better algorithm that performs better in Hotspot, although it compresses to a different byte array, we are perfectly fine.
If we want to assert for now that both algorithms create the same compressed output, we should have three different size random byte files (e.g. generated by /dev/urandom) as test resources and the C-compressed ones also as test resources, and then we can compare the results. We should just document how the test data was created. But keep in mind: We may change the algorithm to produce different bytes, so this is not mandatory. I think we may only assert that the compression percentage of the random data is identical, not the actual bytes.
> Compare the LZ4 implementation in Lucene against the original impl
> ------------------------------------------------------------------
>
> Key: LUCENE-4584
> URL: https://issues.apache.org/jira/browse/LUCENE-4584
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Fix For: 4.1
>
>
> We should add tests to make sure that the LZ4 impl in Lucene compresses data the exact same way as the original impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Comment Edited] (LUCENE-4584) Compare the LZ4
implementation in Lucene against the original impl
Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508119#comment-13508119 ]
Steven Rowe edited comment on LUCENE-4584 at 12/2/12 12:33 AM:
---------------------------------------------------------------
bq. Steven: We are a Java project and we have no platform independent way to run C code. I think Adrien's idea is enough, maybe use 2 or 3 different length examples. Just like Apache TIKA parading MS Office docs, they also don't start MS Office while testing ♥
I agree Adrien's idea is enough, and in any case is better than what we have now (pnp), but I still think cross-impl testing would be nice.
cpp-tasks is used to compile NativePosixUtil.cpp, so there is precedent for this in our project...
bq. I'm a little worried about adding the sources of LZ4 and a task to compile C code to the lucene-core build (or maybe I could do these LZ4 tests in a dedicated module so that it doesn't make lucene-core depend on native code?).
I think it would be fine to include test-only native code in lucene-core tests, as long as compilation and testing were both fast.
bq. I think we should also compare the output bytes to make sure the compressor is efficient. [...] Given that the LZ4 output depends on the endianess of the machine, this can unfortunately only be done with static files.
You wouldn't need static files if you compared output lengths, though correctness would of course no longer be implied.
was (Author: steve_rowe):
bq. Steven: We are a Java project and we have no platform independent way to run C code. I think Adrien's idea is enough, maybe use 2 or 3 different length examples. Just like Apache TIKA parading MS Office docs, they also don't start MS Office while testing ♥
I agree Adrien's idea is enough, and in any case is better than what we have now (pnp), but I still think cross-impl testing would be nice.
cpp-tasks is used to compile NativeUnixDirectory.cpp, so there is precedent for this in our project...
bq. I'm a little worried about adding the sources of LZ4 and a task to compile C code to the lucene-core build (or maybe I could do these LZ4 tests in a dedicated module so that it doesn't make lucene-core depend on native code?).
I think it would be fine to include test-only native code in lucene-core tests, as long as compilation and testing were both fast.
bq. I think we should also compare the output bytes to make sure the compressor is efficient. [...] Given that the LZ4 output depends on the endianess of the machine, this can unfortunately only be done with static files.
You wouldn't need static files if you compared output lengths, though correctness would of course no longer be implied.
> Compare the LZ4 implementation in Lucene against the original impl
> ------------------------------------------------------------------
>
> Key: LUCENE-4584
> URL: https://issues.apache.org/jira/browse/LUCENE-4584
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Blocker
> Fix For: 4.1
>
>
> We should add tests to make sure that the LZ4 impl in Lucene compresses data the exact same way as the original impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4584) Compare the LZ4 implementation in
Lucene against the original impl
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-4584:
--------------------------------
Priority: Major (was: Blocker)
> Compare the LZ4 implementation in Lucene against the original impl
> ------------------------------------------------------------------
>
> Key: LUCENE-4584
> URL: https://issues.apache.org/jira/browse/LUCENE-4584
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Fix For: 4.1
>
>
> We should add tests to make sure that the LZ4 impl in Lucene compresses data the exact same way as the original impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4584) Compare the LZ4 implementation in
Lucene against the original impl
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508191#comment-13508191 ]
Uwe Schindler commented on LUCENE-4584:
---------------------------------------
bq. cpp-tasks is used to compile NativePosixUtil.cpp, so there is precedent for this in our project...
-1. THIS IS NOT PART OF OUR BUILD SYSTEM; IT IS NOT EVEN TESTED AT ALL!
> Compare the LZ4 implementation in Lucene against the original impl
> ------------------------------------------------------------------
>
> Key: LUCENE-4584
> URL: https://issues.apache.org/jira/browse/LUCENE-4584
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Blocker
> Fix For: 4.1
>
>
> We should add tests to make sure that the LZ4 impl in Lucene compresses data the exact same way as the original impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4584) Compare the LZ4 implementation in
Lucene against the original impl
Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508104#comment-13508104 ]
Steven Rowe commented on LUCENE-4584:
-------------------------------------
I would be cool to have randomized input to the C code compressor decompressed by the Java code, and vice versa :). (Much better than static compressed C code results.)
> Compare the LZ4 implementation in Lucene against the original impl
> ------------------------------------------------------------------
>
> Key: LUCENE-4584
> URL: https://issues.apache.org/jira/browse/LUCENE-4584
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Blocker
> Fix For: 4.1
>
>
> We should add tests to make sure that the LZ4 impl in Lucene compresses data the exact same way as the original impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4584) Compare the LZ4 implementation in
Lucene against the original impl
Posted by "Adrien Grand (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508270#comment-13508270 ]
Adrien Grand commented on LUCENE-4584:
--------------------------------------
bq. You wouldn't need static files if you compared output lengths
Even the output length depends on the endianess: LZ4 uses a hash table without collision resolution (it maps hash -> last offset that produced this hash) to find matchs of 4 consecutive bytes in the input bytes, and this hash function is not endian-neutral (it interprets the 4 bytes as an 32-bits int, multiplies it by a prime number and keeps the 12 first bits (13 if there are less than 2^16 input bytes)), so the collisions won't be the same depending on the endianess and LZ4 won't find the same matchs.
> Compare the LZ4 implementation in Lucene against the original impl
> ------------------------------------------------------------------
>
> Key: LUCENE-4584
> URL: https://issues.apache.org/jira/browse/LUCENE-4584
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Fix For: 4.1
>
>
> We should add tests to make sure that the LZ4 impl in Lucene compresses data the exact same way as the original impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-4584) Compare the LZ4 implementation in
Lucene against the original impl
Posted by "Adrien Grand (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrien Grand resolved LUCENE-4584.
----------------------------------
Resolution: Won't Fix
Comparing the compressed output against the original impl seemed to be a good mean to detect bugs, but if we want to be able to have a different algorithm as Uwe suggests, I'll try to add softer tests (like checking that the algorithm manages to detect a match which is 65535 bytes backwards, gives a reasonable compression ratio on inputs that are known to be easily compressible, etc.)
> Compare the LZ4 implementation in Lucene against the original impl
> ------------------------------------------------------------------
>
> Key: LUCENE-4584
> URL: https://issues.apache.org/jira/browse/LUCENE-4584
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Fix For: 4.1
>
>
> We should add tests to make sure that the LZ4 impl in Lucene compresses data the exact same way as the original impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4584) Compare the LZ4 implementation in
Lucene against the original impl
Posted by "Adrien Grand (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508103#comment-13508103 ]
Adrien Grand commented on LUCENE-4584:
--------------------------------------
I have planned to add example of files compressed with the C version to Lucene's svn repo and add tests that check that our impl generate the same compressed bytes. This would make me more confident that our impl compresses data efficiently and that it does not have bugs.
> Compare the LZ4 implementation in Lucene against the original impl
> ------------------------------------------------------------------
>
> Key: LUCENE-4584
> URL: https://issues.apache.org/jira/browse/LUCENE-4584
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Blocker
> Fix For: 4.1
>
>
> We should add tests to make sure that the LZ4 impl in Lucene compresses data the exact same way as the original impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4584) Compare the LZ4 implementation in
Lucene against the original impl
Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508119#comment-13508119 ]
Steven Rowe commented on LUCENE-4584:
-------------------------------------
bq. Steven: We are a Java project and we have no platform independent way to run C code. I think Adrien's idea is enough, maybe use 2 or 3 different length examples. Just like Apache TIKA parading MS Office docs, they also don't start MS Office while testing ♥
I agree Adrien's idea is enough, and in any case is better than what we have now (pnp), but I still think cross-impl testing would be nice.
cpp-tasks is used to compile NativeUnixDirectory.cpp, so there is precedent for this in our project...
bq. I'm a little worried about adding the sources of LZ4 and a task to compile C code to the lucene-core build (or maybe I could do these LZ4 tests in a dedicated module so that it doesn't make lucene-core depend on native code?).
I think it would be fine to include test-only native code in lucene-core tests, as long as compilation and testing were both fast.
bq. I think we should also compare the output bytes to make sure the compressor is efficient. [...] Given that the LZ4 output depends on the endianess of the machine, this can unfortunately only be done with static files.
You wouldn't need static files if you compared output lengths, though correctness would of course no longer be implied.
> Compare the LZ4 implementation in Lucene against the original impl
> ------------------------------------------------------------------
>
> Key: LUCENE-4584
> URL: https://issues.apache.org/jira/browse/LUCENE-4584
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Blocker
> Fix For: 4.1
>
>
> We should add tests to make sure that the LZ4 impl in Lucene compresses data the exact same way as the original impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Comment Edited] (LUCENE-4584) Compare the LZ4
implementation in Lucene against the original impl
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508191#comment-13508191 ]
Uwe Schindler edited comment on LUCENE-4584 at 12/2/12 9:10 AM:
----------------------------------------------------------------
bq. cpp-tasks is used to compile NativePosixUtil.cpp, so there is precedent for this in our project...
-1. THIS IS NOT PART OF OUR (OFFICIALLY SUPPORTED) BUILD SYSTEM; IT IS NOT EVEN TESTED AT ALL!
was (Author: thetaphi):
bq. cpp-tasks is used to compile NativePosixUtil.cpp, so there is precedent for this in our project...
-1. THIS IS NOT PART OF OUR BUILD SYSTEM; IT IS NOT EVEN TESTED AT ALL!
> Compare the LZ4 implementation in Lucene against the original impl
> ------------------------------------------------------------------
>
> Key: LUCENE-4584
> URL: https://issues.apache.org/jira/browse/LUCENE-4584
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Blocker
> Fix For: 4.1
>
>
> We should add tests to make sure that the LZ4 impl in Lucene compresses data the exact same way as the original impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4584) Compare the LZ4 implementation in
Lucene against the original impl
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508091#comment-13508091 ]
Uwe Schindler commented on LUCENE-4584:
---------------------------------------
Do you want to run the C code? Oh, oh for platform compatibility...!
> Compare the LZ4 implementation in Lucene against the original impl
> ------------------------------------------------------------------
>
> Key: LUCENE-4584
> URL: https://issues.apache.org/jira/browse/LUCENE-4584
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Blocker
> Fix For: 4.1
>
>
> We should add tests to make sure that the LZ4 impl in Lucene compresses data the exact same way as the original impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4584) Compare the LZ4 implementation in
Lucene against the original impl
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508269#comment-13508269 ]
Robert Muir commented on LUCENE-4584:
-------------------------------------
I'm confused why this is a blocker at all: I'm going to unset it.
I don't actually care if our LZ4 is conformant to the original impl.
I only care that it compresses well, is reasonably fast, and doesn't corrumpt.
> Compare the LZ4 implementation in Lucene against the original impl
> ------------------------------------------------------------------
>
> Key: LUCENE-4584
> URL: https://issues.apache.org/jira/browse/LUCENE-4584
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Blocker
> Fix For: 4.1
>
>
> We should add tests to make sure that the LZ4 impl in Lucene compresses data the exact same way as the original impl.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org