You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by ba...@apache.org on 2006/05/07 22:14:18 UTC
svn commit: r404836 - /jakarta/commons/proper/dbcp/trunk/project.xml
Author: bayard
Date: Sun May 7 13:14:17 2006
New Revision: 404836
URL: http://svn.apache.org/viewcvs?rev=404836&view=rev
Log:
Updating to Collections 3.1 as suggested in #39502
Modified:
jakarta/commons/proper/dbcp/trunk/project.xml
Modified: jakarta/commons/proper/dbcp/trunk/project.xml
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/dbcp/trunk/project.xml?rev=404836&r1=404835&r2=404836&view=diff
==============================================================================
--- jakarta/commons/proper/dbcp/trunk/project.xml (original)
+++ jakarta/commons/proper/dbcp/trunk/project.xml Sun May 7 13:14:17 2006
@@ -177,7 +177,7 @@
<dependency>
<groupId>commons-collections</groupId>
<artifactId>commons-collections</artifactId>
- <version>2.1</version>
+ <version>3.1</version>
</dependency>
<dependency>
<groupId>commons-pool</groupId>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: svn commit: r404836 - /jakarta/commons/proper/dbcp/trunk/project.xml
Posted by Phil Steitz <ph...@gmail.com>.
Are we sure we want to do this? Will it cause problems for others who
depend on [dbcp] now?
The only class used is LRUMap (by SharedPoolDataSource). If we do
make the version change, we should change the import to point to the
non-deprecated collections class in o.a.c.c.map (instead of o.a.c.c).
We might want to consider removing the dependency altogether by
replacing the LRUMap with a simpler fixed size map implementation or
eliminating it. The LRUMap is just used as an instance cache for
UserPassKey instances:
private UserPassKey getUserPassKey(String username, String password) {
UserPassKey key = (UserPassKey) userKeys.get(username);
if (key == null) {
key = new UserPassKey(username, password);
userKeys.put(username, key);
}
return key;
}
I wonder if this really adds much with modern jvms. The UserPassKey
constructor is trivial.
Phil
On 5/7/06, bayard@apache.org <ba...@apache.org> wrote:
> Author: bayard
> Date: Sun May 7 13:14:17 2006
> New Revision: 404836
>
> URL: http://svn.apache.org/viewcvs?rev=404836&view=rev
> Log:
> Updating to Collections 3.1 as suggested in #39502
>
> Modified:
> jakarta/commons/proper/dbcp/trunk/project.xml
>
> Modified: jakarta/commons/proper/dbcp/trunk/project.xml
> URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/dbcp/trunk/project.xml?rev=404836&r1=404835&r2=404836&view=diff
> ==============================================================================
> --- jakarta/commons/proper/dbcp/trunk/project.xml (original)
> +++ jakarta/commons/proper/dbcp/trunk/project.xml Sun May 7 13:14:17 2006
> @@ -177,7 +177,7 @@
> <dependency>
> <groupId>commons-collections</groupId>
> <artifactId>commons-collections</artifactId>
> - <version>2.1</version>
> + <version>3.1</version>
> </dependency>
> <dependency>
> <groupId>commons-pool</groupId>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org