You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Anandha L Ranganahan <an...@gmail.com> on 2013/11/21 09:13:03 UTC

Review Request 15755: HIVE-5810:create a function add_date as exists in mysql

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15755/
-----------------------------------------------------------

Review request for hive and Thejas Nair.


Bugs: https://issues.apache.org/jira/browse/HIVE-5810
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/HIVE-5810


Repository: hive-git


Description
-------

The function add_date(date,unit,expr) and returns the value.

For example,
add_date('2013-11-09','DAY',2) will return 2013-11-11.
add_date('2013-11-09','Month',2) will return 2014-01-09.
add_date('2013-11-09','Year',2) will return 2014-11-11.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddDate.java e69de29 
  ql/src/test/queries/clientpositive/date_udf.q c55b9f9 
  ql/src/test/results/clientpositive/date_udf.q.out 28e4f08 

Diff: https://reviews.apache.org/r/15755/diff/


Testing
-------


Thanks,

Anandha L Ranganahan

Re: Review Request 15755: HIVE-5810:create a function add_date as exists in mysql

Posted by jin jie <he...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15755/#review29221
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddDate.java
<https://reviews.apache.org/r/15755/#comment56358>

    Why these variables are transient?



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddDate.java
<https://reviews.apache.org/r/15755/#comment56359>

    Will unit be null?
    I think we'd better using this form: "YEAR".equalsIgnoreCase(unit)


- jin jie


On Nov. 21, 2013, 8:13 a.m., Anandha L Ranganahan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15755/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2013, 8:13 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/HIVE-5810
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/HIVE-5810
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> The function add_date(date,unit,expr) and returns the value.
> 
> For example,
> add_date('2013-11-09','DAY',2) will return 2013-11-11.
> add_date('2013-11-09','Month',2) will return 2014-01-09.
> add_date('2013-11-09','Year',2) will return 2014-11-11.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddDate.java e69de29 
>   ql/src/test/queries/clientpositive/date_udf.q c55b9f9 
>   ql/src/test/results/clientpositive/date_udf.q.out 28e4f08 
> 
> Diff: https://reviews.apache.org/r/15755/diff/
> 
> 
> Testing
> -------
> 
> Testing complted and attached result.
> 
> 
> Thanks,
> 
> Anandha L Ranganahan
> 
>

Re: Review Request 15755: HIVE-5810:create a function add_date as exists in mysql

Posted by Anandha L Ranganahan <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15755/
-----------------------------------------------------------

(Updated Nov. 23, 2013, 10:07 p.m.)


Review request for hive and Thejas Nair.


Changes
-------

updated patch


Bugs: https://issues.apache.org/jira/browse/HIVE-5810
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/HIVE-5810


Repository: hive-git


Description
-------

The function add_date(date,unit,expr) and returns the value.

For example,
add_date('2013-11-09','DAY',2) will return 2013-11-11.
add_date('2013-11-09','Month',2) will return 2014-01-09.
add_date('2013-11-09','Year',2) will return 2014-11-11.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 435d6e6 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddDate.java e69de29 
  ql/src/test/queries/clientpositive/date_udf.q c55b9f9 
  ql/src/test/results/clientpositive/date_udf.q.out 28e4f08 
  ql/src/test/results/clientpositive/show_functions.q.out 57c9036 

Diff: https://reviews.apache.org/r/15755/diff/


Testing
-------

Testing complted and attached result.


Thanks,

Anandha L Ranganahan

Re: Review Request 15755: HIVE-5810:create a function add_date as exists in mysql

Posted by Anandha L Ranganahan <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15755/
-----------------------------------------------------------

(Updated Nov. 23, 2013, 6:16 p.m.)


Review request for hive and Thejas Nair.


Changes
-------

updated the patch


Bugs: https://issues.apache.org/jira/browse/HIVE-5810
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/HIVE-5810


Repository: hive-git


Description
-------

The function add_date(date,unit,expr) and returns the value.

For example,
add_date('2013-11-09','DAY',2) will return 2013-11-11.
add_date('2013-11-09','Month',2) will return 2014-01-09.
add_date('2013-11-09','Year',2) will return 2014-11-11.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddDate.java e69de29 
  ql/src/test/queries/clientpositive/date_udf.q c55b9f9 
  ql/src/test/results/clientpositive/date_udf.q.out 28e4f08 
  ql/src/test/results/clientpositive/show_functions.q.out 57c9036 

Diff: https://reviews.apache.org/r/15755/diff/


Testing
-------

Testing complted and attached result.


Thanks,

Anandha L Ranganahan

Re: Review Request 15755: HIVE-5810:create a function add_date as exists in mysql

Posted by Jie Jin <he...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15755/#review29222
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
<https://reviews.apache.org/r/15755/#comment56360>

    We already have a date_add.
    The two function date_add and add_date coexist in hive UDF will make people confused.


- Jie Jin


On Nov. 21, 2013, 8:13 a.m., Anandha L Ranganahan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15755/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2013, 8:13 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/HIVE-5810
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/HIVE-5810
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> The function add_date(date,unit,expr) and returns the value.
> 
> For example,
> add_date('2013-11-09','DAY',2) will return 2013-11-11.
> add_date('2013-11-09','Month',2) will return 2014-01-09.
> add_date('2013-11-09','Year',2) will return 2014-11-11.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddDate.java e69de29 
>   ql/src/test/queries/clientpositive/date_udf.q c55b9f9 
>   ql/src/test/results/clientpositive/date_udf.q.out 28e4f08 
> 
> Diff: https://reviews.apache.org/r/15755/diff/
> 
> 
> Testing
> -------
> 
> Testing complted and attached result.
> 
> 
> Thanks,
> 
> Anandha L Ranganahan
> 
>

Re: Review Request 15755: HIVE-5810:create a function add_date as exists in mysql

Posted by Anandha L Ranganahan <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15755/
-----------------------------------------------------------

(Updated Nov. 21, 2013, 8:13 a.m.)


Review request for hive and Thejas Nair.


Bugs: https://issues.apache.org/jira/browse/HIVE-5810
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/HIVE-5810


Repository: hive-git


Description
-------

The function add_date(date,unit,expr) and returns the value.

For example,
add_date('2013-11-09','DAY',2) will return 2013-11-11.
add_date('2013-11-09','Month',2) will return 2014-01-09.
add_date('2013-11-09','Year',2) will return 2014-11-11.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddDate.java e69de29 
  ql/src/test/queries/clientpositive/date_udf.q c55b9f9 
  ql/src/test/results/clientpositive/date_udf.q.out 28e4f08 

Diff: https://reviews.apache.org/r/15755/diff/


Testing (updated)
-------

Testing complted and attached result.


Thanks,

Anandha L Ranganahan

Re: Review Request 15755: HIVE-5810:create a function add_date as exists in mysql

Posted by Anandha L Ranganahan <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15755/
-----------------------------------------------------------

(Updated Nov. 21, 2013, 8:13 a.m.)


Review request for hive and Thejas Nair.


Bugs: https://issues.apache.org/jira/browse/HIVE-5810
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/HIVE-5810


Repository: hive-git


Description
-------

The function add_date(date,unit,expr) and returns the value.

For example,
add_date('2013-11-09','DAY',2) will return 2013-11-11.
add_date('2013-11-09','Month',2) will return 2014-01-09.
add_date('2013-11-09','Year',2) will return 2014-11-11.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddDate.java e69de29 
  ql/src/test/queries/clientpositive/date_udf.q c55b9f9 
  ql/src/test/results/clientpositive/date_udf.q.out 28e4f08 

Diff: https://reviews.apache.org/r/15755/diff/


Testing
-------


Thanks,

Anandha L Ranganahan