You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Kirk True (Jira)" <ji...@apache.org> on 2024/10/07 04:05:00 UTC
[jira] [Updated] (KAFKA-15556) Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect
[ https://issues.apache.org/jira/browse/KAFKA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kirk True updated KAFKA-15556:
------------------------------
Fix Version/s: (was: 4.0.0)
> Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect
> -----------------------------------------------------------------------------------------
>
> Key: KAFKA-15556
> URL: https://issues.apache.org/jira/browse/KAFKA-15556
> Project: Kafka
> Issue Type: Improvement
> Components: clients, consumer
> Reporter: Kirk True
> Assignee: Phuc Hong Tran
> Priority: Minor
> Labels: consumer-threading-refactor
>
> The "new consumer" (i.e. {{{}PrototypeAsyncConsumer{}}}) was designed to handle networking details in a more centralized way. However, in order to reuse code between the existing {{KafkaConsumer}} and the new {{{}PrototypeAsyncConsumer{}}}, that design goal was "relaxed" when the {{NetworkClientDelegate}} capitulated and -stole- copied three methods from {{ConsumerNetworkClient}} related to detecting node status:
> # {{isUnavailable}}
> # {{maybeThrowAuthFailure}}
> # {{tryConnect}}
> Unfortunately, these have found their way into the {{FetchRequestManager}} and {{OffsetsRequestManager}} implementations. We should review if we can clean up—or even remove—this leaky abstraction.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)