You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/05/22 11:43:07 UTC

Review Request 59447: RANGER-1601 The log name is incorrect in ValuePrinter.java

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59447/
-----------------------------------------------------------

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1601
    https://issues.apache.org/jira/browse/RANGER-1601


Repository: ranger


Description
-------

The log name should use 'ValuePrinter.class' instead of 'RangerGeolocationDatabase.class' in ValuePrinter.java.
Change from 'private static final Log LOG = LogFactory.getLog(RangerGeolocationDatabase.class);' to 'private static final Log LOG = LogFactory.getLog(ValuePrinter.class);'


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/geo/ValuePrinter.java 89bb0b40 


Diff: https://reviews.apache.org/r/59447/diff/1/


Testing
-------


Thanks,

pengjianhua


Re: Review Request 59447: RANGER-1601 The log name is incorrect in ValuePrinter.java

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59447/#review175633
-----------------------------------------------------------


Ship it!




Ship It!

- Colm O hEigeartaigh


On May 22, 2017, 11:43 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59447/
> -----------------------------------------------------------
> 
> (Updated May 22, 2017, 11:43 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1601
>     https://issues.apache.org/jira/browse/RANGER-1601
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The log name should use 'ValuePrinter.class' instead of 'RangerGeolocationDatabase.class' in ValuePrinter.java.
> Change from 'private static final Log LOG = LogFactory.getLog(RangerGeolocationDatabase.class);' to 'private static final Log LOG = LogFactory.getLog(ValuePrinter.class);'
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/geo/ValuePrinter.java 89bb0b40 
> 
> 
> Diff: https://reviews.apache.org/r/59447/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>