You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "cxzl25 (via GitHub)" <gi...@apache.org> on 2023/06/16 13:35:28 UTC
[GitHub] [incubator-celeborn] cxzl25 opened a new pull request, #1600: [MINOR] Cleanup code
cxzl25 opened a new pull request, #1600:
URL: https://github.com/apache/incubator-celeborn/pull/1600
### What changes were proposed in this pull request?
1. Use `<arg>-Ywarn-unused-import</arg>` to remove some unused imports
2. Fix scala case match not fully covered, avoid `scala.MatchError`.
3. Fixed some scala compilation warnings
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture closed pull request #1600: [CELEBORN-690][MINOR] Cleanup code
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #1600: [CELEBORN-690][MINOR] Cleanup code
URL: https://github.com/apache/incubator-celeborn/pull/1600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] cxzl25 commented on a diff in pull request #1600: [MINOR] Cleanup code
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #1600:
URL: https://github.com/apache/incubator-celeborn/pull/1600#discussion_r1233236495
##########
common/src/main/scala/org/apache/celeborn/common/metrics/MetricsSystem.scala:
##########
@@ -109,7 +109,7 @@ class MetricsSystem(
sourceConfigs.foreach { kv =>
val classPath = kv._2.getProperty("class")
try {
- val source = Utils.classForName(classPath).newInstance()
+ val source = Utils.classForName(classPath).getDeclaredConstructor().newInstance()
Review Comment:
JDK11
> MetricsSystem.scala:112: method newInstance in class Class is deprecated: see corresponding Javadoc for more information.
##########
common/src/main/scala/org/apache/celeborn/common/protocol/message/ControlMessages.scala:
##########
@@ -734,7 +734,7 @@ object ControlMessages extends Logging {
.setShuffleId(shuffleId)
.addAllMasterIds(masterIds)
.addAllSlaveIds(slaveIds)
- .addAllMapAttempts(mapAttempts.map(new Integer(_)).toIterable.asJava)
+ .addAllMapAttempts(mapAttempts.map(Integer.valueOf).toIterable.asJava)
Review Comment:
> ControlMessages.scala:737: constructor Integer in class Integer is deprecated: see corresponding Javadoc for more information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] cfmcgrady commented on a diff in pull request #1600: [MINOR] Cleanup code
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on code in PR #1600:
URL: https://github.com/apache/incubator-celeborn/pull/1600#discussion_r1233100918
##########
pom.xml:
##########
@@ -680,6 +680,15 @@
</execution>
-->
</executions>
+ <configuration>
+ <args>
+ <arg>-unchecked</arg>
+ <arg>-deprecation</arg>
+ <arg>-feature</arg>
+ <arg>-explaintypes</arg>
+ <arg>-Xfatal-warnings</arg>
Review Comment:
then we need to update the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1600: [MINOR] Cleanup code
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1600:
URL: https://github.com/apache/incubator-celeborn/pull/1600#discussion_r1233172375
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -991,7 +995,7 @@ class PushDataHandler extends BaseMessageHandler with Logging {
val (messageMaster, messageSlave) =
messageType match {
- case Type.PUSH_DATA | Type.PUSH_DATA_HAND_SHAKE =>
Review Comment:
so this is a bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] cxzl25 commented on a diff in pull request #1600: [MINOR] Cleanup code
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #1600:
URL: https://github.com/apache/incubator-celeborn/pull/1600#discussion_r1233235897
##########
common/src/main/scala/org/apache/celeborn/common/metrics/source/AbstractSource.scala:
##########
@@ -421,7 +421,7 @@ class TimerSupplier(val slidingWindowSize: Int)
class GaugeSupplier[T](f: Unit => T) extends MetricRegistry.MetricSupplier[Gauge[_]] {
override def newMetric(): Gauge[T] = {
new Gauge[T] {
- override def getValue: T = f()
+ override def getValue: T = f(())
Review Comment:
> AbstractSource.scala:424: Adaptation of argument list by inserting () has been deprecated: this is unlikely to be what you want.
signature: Function1.apply(v1: T1): R
given arguments: <none>
after adaptation: Function1((): Unit)
https://stackoverflow.com/a/25354165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] cxzl25 commented on a diff in pull request #1600: [MINOR] Cleanup code
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #1600:
URL: https://github.com/apache/incubator-celeborn/pull/1600#discussion_r1233233194
##########
common/src/main/scala/org/apache/celeborn/common/util/FunctionConverter.scala:
##########
@@ -17,6 +17,8 @@
package org.apache.celeborn.common.util
+import scala.language.implicitConversions
Review Comment:
> FunctionConverter.scala:26: implicit conversion method scalaFunctionToJava should be enabled
by making the implicit value scala.language.implicitConversions visible.
This can be achieved by adding the import clause 'import scala.language.implicitConversions'
or by setting the compiler option -language:implicitConversions.
See the Scaladoc for value scala.language.implicitConversions for a discussion
why the feature should be explicitly enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1600: [MINOR] Cleanup code
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1600:
URL: https://github.com/apache/incubator-celeborn/pull/1600#issuecomment-1594701763
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1600?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1600](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1600?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0e1f1dc) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/7d7107d607b853ab61b8299f83de2e3dacfa7e3c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7d7107d) will **decrease** coverage by `0.02%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 0e1f1dc differs from pull request most recent head 1f33b4b. Consider uploading reports for the commit 1f33b4b to get more accurate results
```diff
@@ Coverage Diff @@
## main #1600 +/- ##
==========================================
- Coverage 45.81% 45.79% -0.02%
==========================================
Files 159 159
Lines 9950 9949 -1
Branches 970 970
==========================================
- Hits 4558 4555 -3
- Misses 5094 5096 +2
Partials 298 298
```
| [Impacted Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...eleborn/common/internal/config/ConfigBuilder.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL2ludGVybmFsL2NvbmZpZy9Db25maWdCdWlsZGVyLnNjYWxh) | `77.56% <ø> (ø)` | |
| [.../celeborn/common/internal/config/ConfigEntry.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL2ludGVybmFsL2NvbmZpZy9Db25maWdFbnRyeS5zY2FsYQ==) | `78.90% <ø> (ø)` | |
| [...orn/common/meta/ShufflePartitionLocationInfo.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL21ldGEvU2h1ZmZsZVBhcnRpdGlvbkxvY2F0aW9uSW5mby5zY2FsYQ==) | `0.00% <ø> (ø)` | |
| [...a/org/apache/celeborn/common/meta/WorkerInfo.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL21ldGEvV29ya2VySW5mby5zY2FsYQ==) | `55.56% <ø> (-1.85%)` | :arrow_down: |
| [...apache/celeborn/common/metrics/MetricsSystem.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL21ldHJpY3MvTWV0cmljc1N5c3RlbS5zY2FsYQ==) | `12.00% <0.00%> (ø)` | |
| [...eleborn/common/metrics/source/AbstractSource.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL21ldHJpY3Mvc291cmNlL0Fic3RyYWN0U291cmNlLnNjYWxh) | `35.13% <0.00%> (ø)` | |
| [...che/celeborn/common/metrics/source/JVMSource.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL21ldHJpY3Mvc291cmNlL0pWTVNvdXJjZS5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...pache/celeborn/common/util/FunctionConverter.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3V0aWwvRnVuY3Rpb25Db252ZXJ0ZXIuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [.../org/apache/celeborn/common/util/ThreadUtils.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3V0aWwvVGhyZWFkVXRpbHMuc2NhbGE=) | `36.18% <ø> (ø)` | |
| [.../scala/org/apache/celeborn/common/util/Utils.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3V0aWwvVXRpbHMuc2NhbGE=) | `17.55% <ø> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] cxzl25 commented on a diff in pull request #1600: [MINOR] Cleanup code
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #1600:
URL: https://github.com/apache/incubator-celeborn/pull/1600#discussion_r1232267310
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -991,7 +995,7 @@ class PushDataHandler extends BaseMessageHandler with Logging {
val (messageMaster, messageSlave) =
messageType match {
- case Type.PUSH_DATA | Type.PUSH_DATA_HAND_SHAKE =>
Review Comment:
duplicate match
https://github.com/apache/incubator-celeborn/blob/7d7107d607b853ab61b8299f83de2e3dacfa7e3c/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala#L994-L1000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] cfmcgrady commented on a diff in pull request #1600: [MINOR] Cleanup code
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on code in PR #1600:
URL: https://github.com/apache/incubator-celeborn/pull/1600#discussion_r1233100735
##########
common/src/main/scala/org/apache/celeborn/common/util/FunctionConverter.scala:
##########
@@ -17,6 +17,8 @@
package org.apache.celeborn.common.util
+import scala.language.implicitConversions
Review Comment:
why do we need this import?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] cxzl25 commented on a diff in pull request #1600: [MINOR] Cleanup code
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #1600:
URL: https://github.com/apache/incubator-celeborn/pull/1600#discussion_r1233234879
##########
tests/flink-it/src/test/scala/org/apache/celeborn/tests/flink/WordCountTest.scala:
##########
@@ -60,7 +60,6 @@ class WordCountTest extends AnyFunSuite with Logging with MiniClusterFeature
"org.apache.celeborn.plugin.flink.RemoteShuffleServiceFactory")
configuration.setString("celeborn.master.endpoints", "localhost:9097")
configuration.setString("execution.batch-shuffle-mode", "ALL_EXCHANGES_BLOCKING")
- configuration.setBoolean(ConfigConstants.LOCAL_START_WEBSERVER, true)
Review Comment:
Deprecate ConfigConstants.LOCAL_START_WEBSERVER
https://issues.apache.org/jira/browse/FLINK-13828
Fix Version/s: 1.10.0
> Exactly ConfigConstants.LOCAL_START_WEBSERVER has no power any more
##########
tests/flink-it/src/test/scala/org/apache/celeborn/tests/flink/WordCountTest.scala:
##########
@@ -70,7 +69,6 @@ class WordCountTest extends AnyFunSuite with Logging with MiniClusterFeature
val env = StreamExecutionEnvironment.createLocalEnvironmentWithWebUI(configuration)
env.getConfig.setExecutionMode(ExecutionMode.BATCH)
env.getConfig.setParallelism(parallelism)
- env.getConfig.setDefaultInputDependencyConstraint(InputDependencyConstraint.ALL)
Review Comment:
[FLINK-20619][runtime] Remove unused InputDependencyConstraint
https://issues.apache.org/jira/browse/FLINK-20619
Fix Version/s:1.13.0
> It is no longer needed since both legacy scheduler and lazy-from-sources are removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1600: [MINOR] Cleanup code
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1600:
URL: https://github.com/apache/incubator-celeborn/pull/1600#discussion_r1233236113
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -991,7 +995,7 @@ class PushDataHandler extends BaseMessageHandler with Logging {
val (messageMaster, messageSlave) =
messageType match {
- case Type.PUSH_DATA | Type.PUSH_DATA_HAND_SHAKE =>
Review Comment:
better to make separated PR for such cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] cxzl25 commented on a diff in pull request #1600: [MINOR] Cleanup code
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #1600:
URL: https://github.com/apache/incubator-celeborn/pull/1600#discussion_r1233236777
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -991,7 +995,7 @@ class PushDataHandler extends BaseMessageHandler with Logging {
val (messageMaster, messageSlave) =
messageType match {
- case Type.PUSH_DATA | Type.PUSH_DATA_HAND_SHAKE =>
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] cxzl25 commented on a diff in pull request #1600: [MINOR] Cleanup code
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #1600:
URL: https://github.com/apache/incubator-celeborn/pull/1600#discussion_r1232265185
##########
pom.xml:
##########
@@ -680,6 +680,15 @@
</execution>
-->
</executions>
+ <configuration>
+ <args>
+ <arg>-unchecked</arg>
+ <arg>-deprecation</arg>
+ <arg>-feature</arg>
+ <arg>-explaintypes</arg>
+ <arg>-Xfatal-warnings</arg>
Review Comment:
There is no way to use `<arg>-Ywarn-unused-import</arg>` at this stage
Because we have the following code
```
// Can Remove this if celeborn don't support scala211 in future
import org.apache.celeborn.common.util.FunctionConverter._
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] cxzl25 commented on a diff in pull request #1600: [MINOR] Cleanup code
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #1600:
URL: https://github.com/apache/incubator-celeborn/pull/1600#discussion_r1233234277
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -991,7 +995,7 @@ class PushDataHandler extends BaseMessageHandler with Logging {
val (messageMaster, messageSlave) =
messageType match {
- case Type.PUSH_DATA | Type.PUSH_DATA_HAND_SHAKE =>
Review Comment:
> PushDataHandler.scala:1003: unreachable code
> so this is a bug?
I think so.
The status code is just passed to `CelebornIOException`, so probably doesn't affect anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] cxzl25 commented on a diff in pull request #1600: [MINOR] Cleanup code
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #1600:
URL: https://github.com/apache/incubator-celeborn/pull/1600#discussion_r1233236725
##########
common/src/main/scala/org/apache/celeborn/common/protocol/message/ControlMessages.scala:
##########
@@ -734,7 +734,7 @@ object ControlMessages extends Logging {
.setShuffleId(shuffleId)
.addAllMasterIds(masterIds)
.addAllSlaveIds(slaveIds)
- .addAllMapAttempts(mapAttempts.map(new Integer(_)).toIterable.asJava)
+ .addAllMapAttempts(mapAttempts.map(Integer.valueOf).toIterable.asJava)
Review Comment:
JDK11
> ControlMessages.scala:737: constructor Integer in class Integer is deprecated: see corresponding Javadoc for more information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] cxzl25 commented on a diff in pull request #1600: [MINOR] Cleanup code
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #1600:
URL: https://github.com/apache/incubator-celeborn/pull/1600#discussion_r1233234657
##########
pom.xml:
##########
@@ -680,6 +680,15 @@
</execution>
-->
</executions>
+ <configuration>
+ <args>
+ <arg>-unchecked</arg>
+ <arg>-deprecation</arg>
+ <arg>-feature</arg>
+ <arg>-explaintypes</arg>
+ <arg>-Xfatal-warnings</arg>
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org