You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/06 18:19:05 UTC
[GitHub] [airflow] nuclearpinguin opened a new pull request #7083:
[AIRFLOW-6490] Improve time delta comparison in local task job tests
nuclearpinguin opened a new pull request #7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
URL: https://github.com/apache/airflow/pull/7083
This PR eliminates small flakiness from local task job that occurs when something happens faster"
```
AssertionError: 1.996401 not greater than or equal to 2
```
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
- [ ] Description above provides context of the change
- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7083:
[AIRFLOW-6490] Improve time delta comparison in local task job tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
URL: https://github.com/apache/airflow/pull/7083#issuecomment-571267246
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=h1) Report
> Merging [#7083](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/64204d3d605b6bd37b09a7347da77acc31df2269?src=pr&el=desc) will **decrease** coverage by `0.2%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7083 +/- ##
==========================================
- Coverage 84.98% 84.78% -0.21%
==========================================
Files 680 680
Lines 38753 38753
==========================================
- Hits 32935 32856 -79
- Misses 5818 5897 +79
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `84.61% <0%> (+1.28%)` | :arrow_up: |
| [airflow/hooks/postgres\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wb3N0Z3Jlc19ob29rLnB5) | `94.36% <0%> (+1.4%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+1.65%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+1.66%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=footer). Last update [64204d3...421c739](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7083:
[AIRFLOW-6490] Improve time delta comparison in local task job tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
URL: https://github.com/apache/airflow/pull/7083#issuecomment-571267246
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=h1) Report
> Merging [#7083](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/64204d3d605b6bd37b09a7347da77acc31df2269?src=pr&el=desc) will **decrease** coverage by `0.2%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7083 +/- ##
==========================================
- Coverage 84.98% 84.78% -0.21%
==========================================
Files 680 680
Lines 38753 38753
==========================================
- Hits 32935 32856 -79
- Misses 5818 5897 +79
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `84.61% <0%> (+1.28%)` | :arrow_up: |
| [airflow/hooks/postgres\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wb3N0Z3Jlc19ob29rLnB5) | `94.36% <0%> (+1.4%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+1.65%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+1.66%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=footer). Last update [64204d3...421c739](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on a change in pull request
#7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on a change in pull request #7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
URL: https://github.com/apache/airflow/pull/7083#discussion_r364303781
##########
File path: tests/jobs/test_local_task_job.py
##########
@@ -159,7 +159,10 @@ def test_heartbeat_failed_fast(self, mock_getpid):
for i in range(1, len(heartbeat_records)):
time1 = heartbeat_records[i - 1]
time2 = heartbeat_records[i]
- self.assertGreaterEqual((time2 - time1).total_seconds(), job.heartrate)
+ # Assert that difference small enough to avoid:
+ # AssertionError: 1.996401 not greater than or equal to 2
+ delta = abs((time2 - time1).total_seconds() - job.heartrate)
+ self.assertLessEqual(delta, 0.005)
Review comment:
Here we go again... 😜 unittests have `assertAlmostEqual` that do the same thing. But I decided to be explicit, in math when you want to be sure that something is "the same thing" you assert that the difference is small enough (null set) 🤷🏼♂️
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7083:
[AIRFLOW-6490] Improve time delta comparison in local task job tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
URL: https://github.com/apache/airflow/pull/7083#issuecomment-571267246
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=h1) Report
> Merging [#7083](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/64204d3d605b6bd37b09a7347da77acc31df2269?src=pr&el=desc) will **decrease** coverage by `0.2%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7083 +/- ##
==========================================
- Coverage 84.98% 84.78% -0.21%
==========================================
Files 680 680
Lines 38753 38753
==========================================
- Hits 32935 32856 -79
- Misses 5818 5897 +79
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `84.61% <0%> (+1.28%)` | :arrow_up: |
| [airflow/hooks/postgres\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wb3N0Z3Jlc19ob29rLnB5) | `94.36% <0%> (+1.4%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+1.65%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+1.66%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=footer). Last update [64204d3...421c739](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #7083:
[AIRFLOW-6490] Improve time delta comparison in local task job tests
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
URL: https://github.com/apache/airflow/pull/7083#discussion_r363442725
##########
File path: tests/jobs/test_local_task_job.py
##########
@@ -159,7 +159,10 @@ def test_heartbeat_failed_fast(self, mock_getpid):
for i in range(1, len(heartbeat_records)):
time1 = heartbeat_records[i - 1]
time2 = heartbeat_records[i]
- self.assertGreaterEqual((time2 - time1).total_seconds(), job.heartrate)
+ # Assert that difference small enough to avoid:
+ # AssertionError: 1.996401 not greater than or equal to 2
+ delta = abs((time2 - time1).total_seconds() - job.heartrate)
+ self.assertLessEqual(delta, 0.005)
Review comment:
What do you think about using pytest.approx?
https://docs.pytest.org/en/latest/reference.html#id13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7083:
[AIRFLOW-6490] Improve time delta comparison in local task job tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
URL: https://github.com/apache/airflow/pull/7083#issuecomment-571267246
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=h1) Report
> Merging [#7083](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/64204d3d605b6bd37b09a7347da77acc31df2269?src=pr&el=desc) will **decrease** coverage by `0.2%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7083 +/- ##
==========================================
- Coverage 84.98% 84.78% -0.21%
==========================================
Files 680 680
Lines 38753 38753
==========================================
- Hits 32935 32856 -79
- Misses 5818 5897 +79
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `84.61% <0%> (+1.28%)` | :arrow_up: |
| [airflow/hooks/postgres\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wb3N0Z3Jlc19ob29rLnB5) | `94.36% <0%> (+1.4%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+1.65%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+1.66%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=footer). Last update [64204d3...421c739](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7083:
[AIRFLOW-6490] Improve time delta comparison in local task job tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
URL: https://github.com/apache/airflow/pull/7083#issuecomment-571267246
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=h1) Report
> Merging [#7083](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/64204d3d605b6bd37b09a7347da77acc31df2269?src=pr&el=desc) will **decrease** coverage by `0.2%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7083 +/- ##
==========================================
- Coverage 84.98% 84.78% -0.21%
==========================================
Files 680 680
Lines 38753 38753
==========================================
- Hits 32935 32856 -79
- Misses 5818 5897 +79
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `84.61% <0%> (+1.28%)` | :arrow_up: |
| [airflow/hooks/postgres\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wb3N0Z3Jlc19ob29rLnB5) | `94.36% <0%> (+1.4%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+1.65%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+1.66%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=footer). Last update [64204d3...421c739](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7083:
[AIRFLOW-6490] Improve time delta comparison in local task job tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
URL: https://github.com/apache/airflow/pull/7083#issuecomment-571267246
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=h1) Report
> Merging [#7083](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/64204d3d605b6bd37b09a7347da77acc31df2269?src=pr&el=desc) will **decrease** coverage by `0.2%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7083 +/- ##
==========================================
- Coverage 84.98% 84.78% -0.21%
==========================================
Files 680 680
Lines 38753 38753
==========================================
- Hits 32935 32856 -79
- Misses 5818 5897 +79
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `84.61% <0%> (+1.28%)` | :arrow_up: |
| [airflow/hooks/postgres\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wb3N0Z3Jlc19ob29rLnB5) | `94.36% <0%> (+1.4%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+1.65%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+1.66%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=footer). Last update [64204d3...421c739](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7083:
[AIRFLOW-6490] Improve time delta comparison in local task job tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
URL: https://github.com/apache/airflow/pull/7083#issuecomment-571267246
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=h1) Report
> Merging [#7083](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/64204d3d605b6bd37b09a7347da77acc31df2269?src=pr&el=desc) will **decrease** coverage by `0.2%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7083 +/- ##
==========================================
- Coverage 84.98% 84.78% -0.21%
==========================================
Files 680 680
Lines 38753 38753
==========================================
- Hits 32935 32856 -79
- Misses 5818 5897 +79
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `84.61% <0%> (+1.28%)` | :arrow_up: |
| [airflow/hooks/postgres\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wb3N0Z3Jlc19ob29rLnB5) | `94.36% <0%> (+1.4%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+1.65%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+1.66%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=footer). Last update [64204d3...421c739](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7083:
[AIRFLOW-6490] Improve time delta comparison in local task job tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
URL: https://github.com/apache/airflow/pull/7083#issuecomment-571267246
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=h1) Report
> Merging [#7083](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6cbedf8775df77c623f5ca5cace24ed4eecd6a5b?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7083 +/- ##
==========================================
- Coverage 85.06% 84.78% -0.29%
==========================================
Files 680 680
Lines 38753 38753
==========================================
- Hits 32965 32856 -109
- Misses 5788 5897 +109
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `84.61% <0%> (+1.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=footer). Last update [6cbedf8...421c739](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7083: [AIRFLOW-6490]
Improve time delta comparison in local task job tests
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
URL: https://github.com/apache/airflow/pull/7083#issuecomment-571267246
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=h1) Report
> Merging [#7083](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6cbedf8775df77c623f5ca5cace24ed4eecd6a5b?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7083 +/- ##
==========================================
- Coverage 85.06% 84.78% -0.29%
==========================================
Files 680 680
Lines 38753 38753
==========================================
- Hits 32965 32856 -109
- Misses 5788 5897 +109
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `84.61% <0%> (+1.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=footer). Last update [6cbedf8...421c739](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on a change in pull request
#7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on a change in pull request #7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
URL: https://github.com/apache/airflow/pull/7083#discussion_r364303781
##########
File path: tests/jobs/test_local_task_job.py
##########
@@ -159,7 +159,10 @@ def test_heartbeat_failed_fast(self, mock_getpid):
for i in range(1, len(heartbeat_records)):
time1 = heartbeat_records[i - 1]
time2 = heartbeat_records[i]
- self.assertGreaterEqual((time2 - time1).total_seconds(), job.heartrate)
+ # Assert that difference small enough to avoid:
+ # AssertionError: 1.996401 not greater than or equal to 2
+ delta = abs((time2 - time1).total_seconds() - job.heartrate)
+ self.assertLessEqual(delta, 0.005)
Review comment:
Here we go again... 😜 unittests have `assertAlmostEqual` that do the same thing. But I decided to be explicit, in math when you want to be sure that something is "the same thing" you assert that de difference is small enough (null set) 🤷🏼♂️
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7083:
[AIRFLOW-6490] Improve time delta comparison in local task job tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
URL: https://github.com/apache/airflow/pull/7083#issuecomment-571267246
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=h1) Report
> Merging [#7083](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/64204d3d605b6bd37b09a7347da77acc31df2269?src=pr&el=desc) will **decrease** coverage by `0.2%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7083 +/- ##
==========================================
- Coverage 84.98% 84.78% -0.21%
==========================================
Files 680 680
Lines 38753 38753
==========================================
- Hits 32935 32856 -79
- Misses 5818 5897 +79
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `84.61% <0%> (+1.28%)` | :arrow_up: |
| [airflow/hooks/postgres\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wb3N0Z3Jlc19ob29rLnB5) | `94.36% <0%> (+1.4%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+1.65%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+1.66%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=footer). Last update [64204d3...421c739](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7083:
[AIRFLOW-6490] Improve time delta comparison in local task job tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
URL: https://github.com/apache/airflow/pull/7083#issuecomment-571267246
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=h1) Report
> Merging [#7083](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/64204d3d605b6bd37b09a7347da77acc31df2269?src=pr&el=desc) will **decrease** coverage by `0.2%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7083 +/- ##
==========================================
- Coverage 84.98% 84.78% -0.21%
==========================================
Files 680 680
Lines 38753 38753
==========================================
- Hits 32935 32856 -79
- Misses 5818 5897 +79
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `84.61% <0%> (+1.28%)` | :arrow_up: |
| [airflow/hooks/postgres\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wb3N0Z3Jlc19ob29rLnB5) | `94.36% <0%> (+1.4%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+1.65%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+1.66%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=footer). Last update [64204d3...421c739](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7083:
[AIRFLOW-6490] Improve time delta comparison in local task job tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
URL: https://github.com/apache/airflow/pull/7083#issuecomment-571267246
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=h1) Report
> Merging [#7083](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/64204d3d605b6bd37b09a7347da77acc31df2269?src=pr&el=desc) will **decrease** coverage by `0.2%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7083 +/- ##
==========================================
- Coverage 84.98% 84.78% -0.21%
==========================================
Files 680 680
Lines 38753 38753
==========================================
- Hits 32935 32856 -79
- Misses 5818 5897 +79
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `84.61% <0%> (+1.28%)` | :arrow_up: |
| [airflow/hooks/postgres\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wb3N0Z3Jlc19ob29rLnB5) | `94.36% <0%> (+1.4%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+1.65%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+1.66%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=footer). Last update [64204d3...421c739](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7083:
[AIRFLOW-6490] Improve time delta comparison in local task job tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
URL: https://github.com/apache/airflow/pull/7083#issuecomment-571267246
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=h1) Report
> Merging [#7083](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/64204d3d605b6bd37b09a7347da77acc31df2269?src=pr&el=desc) will **decrease** coverage by `0.2%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7083 +/- ##
==========================================
- Coverage 84.98% 84.78% -0.21%
==========================================
Files 680 680
Lines 38753 38753
==========================================
- Hits 32935 32856 -79
- Misses 5818 5897 +79
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `84.61% <0%> (+1.28%)` | :arrow_up: |
| [airflow/hooks/postgres\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wb3N0Z3Jlc19ob29rLnB5) | `94.36% <0%> (+1.4%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+1.65%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+1.66%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=footer). Last update [64204d3...421c739](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7083:
[AIRFLOW-6490] Improve time delta comparison in local task job tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
URL: https://github.com/apache/airflow/pull/7083#issuecomment-571267246
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=h1) Report
> Merging [#7083](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/64204d3d605b6bd37b09a7347da77acc31df2269?src=pr&el=desc) will **decrease** coverage by `0.2%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7083 +/- ##
==========================================
- Coverage 84.98% 84.78% -0.21%
==========================================
Files 680 680
Lines 38753 38753
==========================================
- Hits 32935 32856 -79
- Misses 5818 5897 +79
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `84.61% <0%> (+1.28%)` | :arrow_up: |
| [airflow/hooks/postgres\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wb3N0Z3Jlc19ob29rLnB5) | `94.36% <0%> (+1.4%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+1.65%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+1.66%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=footer). Last update [64204d3...421c739](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7083:
[AIRFLOW-6490] Improve time delta comparison in local task job tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
URL: https://github.com/apache/airflow/pull/7083#issuecomment-571267246
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=h1) Report
> Merging [#7083](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/64204d3d605b6bd37b09a7347da77acc31df2269?src=pr&el=desc) will **decrease** coverage by `0.2%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7083 +/- ##
==========================================
- Coverage 84.98% 84.78% -0.21%
==========================================
Files 680 680
Lines 38753 38753
==========================================
- Hits 32935 32856 -79
- Misses 5818 5897 +79
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `84.61% <0%> (+1.28%)` | :arrow_up: |
| [airflow/hooks/postgres\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wb3N0Z3Jlc19ob29rLnB5) | `94.36% <0%> (+1.4%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+1.65%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+1.66%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=footer). Last update [64204d3...421c739](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin merged pull request #7083: [AIRFLOW-6490]
Improve time delta comparison in local task job tests
Posted by GitBox <gi...@apache.org>.
nuclearpinguin merged pull request #7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
URL: https://github.com/apache/airflow/pull/7083
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7083:
[AIRFLOW-6490] Improve time delta comparison in local task job tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
URL: https://github.com/apache/airflow/pull/7083#issuecomment-571267246
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=h1) Report
> Merging [#7083](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/64204d3d605b6bd37b09a7347da77acc31df2269?src=pr&el=desc) will **decrease** coverage by `0.2%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7083 +/- ##
==========================================
- Coverage 84.98% 84.78% -0.21%
==========================================
Files 680 680
Lines 38753 38753
==========================================
- Hits 32935 32856 -79
- Misses 5818 5897 +79
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `84.61% <0%> (+1.28%)` | :arrow_up: |
| [airflow/hooks/postgres\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wb3N0Z3Jlc19ob29rLnB5) | `94.36% <0%> (+1.4%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+1.65%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+1.66%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=footer). Last update [64204d3...421c739](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7083:
[AIRFLOW-6490] Improve time delta comparison in local task job tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7083: [AIRFLOW-6490] Improve time delta comparison in local task job tests
URL: https://github.com/apache/airflow/pull/7083#issuecomment-571267246
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=h1) Report
> Merging [#7083](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/64204d3d605b6bd37b09a7347da77acc31df2269?src=pr&el=desc) will **decrease** coverage by `0.2%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7083 +/- ##
==========================================
- Coverage 84.98% 84.78% -0.21%
==========================================
Files 680 680
Lines 38753 38753
==========================================
- Hits 32935 32856 -79
- Misses 5818 5897 +79
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `84.61% <0%> (+1.28%)` | :arrow_up: |
| [airflow/hooks/postgres\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wb3N0Z3Jlc19ob29rLnB5) | `94.36% <0%> (+1.4%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+1.65%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (+1.66%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/airflow/pull/7083/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=footer). Last update [64204d3...421c739](https://codecov.io/gh/apache/airflow/pull/7083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services