You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/04 23:10:52 UTC
[GitHub] [pulsar] michaeljmarshall commented on pull request #14125: Use `scheduleWithFixedDelay` instead of `scheduleAtFixedRate` for java producer batch timer
michaeljmarshall commented on pull request #14125:
URL: https://github.com/apache/pulsar/pull/14125#issuecomment-1030420161
> I think we could even go further and schedule the task only when the producer is active.
@merlimat - this is a great point. Essentially, we only need a scheduled to a "flush" if there are messages in the `batchMessageContainer`. We could even delay the flush each time that we send messages, since a client that is pushing many messages through the producer will likely hit the batch limit before the flush. Without pushing out the flush, we'll also increase the probability of under-filled batches.
@klevy-toast - are you interested in working on this fix? If not, I think we should merge this and then someone can work on a follow up fix?
I'd argue we could cherry pick this commit to older release branches since it is very well understood.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org