[GitHub] [arrow] nealrichardson commented on a change in pull request #7484: Use neutral wording for selecting and deselecting rules

[GitBox <gi...@apache.org>]

nealrichardson commented on a change in pull request #7484:
URL: https://github.com/apache/arrow/pull/7484#discussion_r442475340



##########
File path: cpp/build-support/cpplint.py
##########
@@ -4008,9 +4008,9 @@ def CheckTrailingSemicolon(filename, clean_lines, linenum, error):
 
   # Block bodies should not be followed by a semicolon.  Due to C++11
   # brace initialization, there are more places where semicolons are
-  # required than not, so we use a whitelist approach to check these
-  # rather than a blacklist.  These are the places where "};" should
-  # be replaced by just "}":
+  # required than not, so we use explicitly list the allowed rules

Review comment:
       This file is vendored; is it ok for us to edit it? (I'll note that https://raw.githubusercontent.com/google/styleguide/gh-pages/cpplint/cpplint.py still says whitelist/blacklist)

##########
File path: dev/archery/archery/cli.py
##########
@@ -318,9 +318,9 @@ def lint(ctx, src, fix, iwyu_all, **checks):
 @click.option("--src", metavar="<arrow_src>", default=None,
               callback=validate_arrow_sources,
               help="Specify Arrow source directory")
-@click.option("--whitelist", "-w", help="Allow only these rules")
-@click.option("--blacklist", "-b", help="Disallow these rules")
-def numpydoc(src, symbols, whitelist, blacklist):
+@click.option("--enable-rule", "-e", multiple=True, help="Allow only these rules")

Review comment:
       Are there docs that need to be updated for this change? Crossbow/GHA jobs that need to be called differently?

##########
File path: cpp/build-support/cpplint.py
##########
@@ -4066,11 +4066,11 @@ def CheckTrailingSemicolon(filename, clean_lines, linenum, error):
     #  - INTERFACE_DEF
     #  - EXCLUSIVE_LOCKS_REQUIRED, SHARED_LOCKS_REQUIRED, LOCKS_EXCLUDED:
     #
-    # We implement a whitelist of safe macros instead of a blacklist of
+    # We implement a list of of safe macros instead of a list of

Review comment:
       ```suggestion
       # We implement a list of safe macros instead of a list of
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org