Re: [PR] [AMORO-3981][FOLLOWUP] Refine the duration format to string [amoro]

["turboFei (via GitHub)" <gi...@apache.org>]

turboFei commented on code in PR #3987:
URL: https://github.com/apache/amoro/pull/3987#discussion_r2594644398


##########
docs/configuration/ams-config.md:
##########
@@ -52,10 +52,10 @@ table td:last-child, table th:last-child { width: 40%; word-break: break-all; }
 | clean-dangling-delete-files.enabled | true | Enable dangling delete files cleaning. |
 | clean-dangling-delete-files.thread-count | 10 | The number of threads used for dangling delete files cleaning. |
 | clean-orphan-files.enabled | true | Enable orphan files cleaning. |
-| clean-orphan-files.interval | 86400000 ms | Interval for cleaning orphan files. |
+| clean-orphan-files.interval | 1 d | Interval for cleaning orphan files. |

Review Comment:
   without
   ```
                 // Use the largest unit if all divide evenly
                 .orElse(orderedUnits.get(orderedUnits.size() - 1));
   ```
   
   It shows `86400000 ms` instead of `1d`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org