[GitHub] [spark] warrenzhu25 commented on pull request #29113: [SPARK-32314][SHS] Add config to control whether log old format of stacktrace

[GitBox <gi...@apache.org>]

warrenzhu25 commented on pull request #29113:
URL: https://github.com/apache/spark/pull/29113#issuecomment-801266142


   > To clarify what I meant:
   > 
   > 1. `ExceptionFailure` is a public api.
   > 2. History server is not the only consumer of event files.
   > 3. There are code paths which are populating `stackTrace` in `ExceptionFailure`
   > 
   > Given all of these, setting stack trace to empty is backwardly incompatible against current spark versions, and breaks compatibility.
   > 
   > I would have been in favour of the change if (3) above was not the case.
   > Given all of these three conditions currently applying, this is a breaking change and I am not in favor of it.
   
   Could you show me one example code path which is populating `stackTrace` in `ExceptionFailure`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org