You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Jmennius (via GitHub)" <gi...@apache.org> on 2023/03/01 17:59:53 UTC

[GitHub] [qpid-proton] Jmennius opened a new pull request, #388: NO-JIRA: [Python] Allow configuration of container ID

Jmennius opened a new pull request, #388:
URL: https://github.com/apache/qpid-proton/pull/388

   This allows simple external configuration of container ID.
   Without it the only way to overwrite or provide custom container ID is to inherit the class.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-proton] Jmennius commented on pull request #388: NO-JIRA: [Python] Allow configuration of container ID

Posted by "Jmennius (via GitHub)" <gi...@apache.org>.
Jmennius commented on PR #388:
URL: https://github.com/apache/qpid-proton/pull/388#issuecomment-1497843962

   > @Jmennius I've merged a neater version of this change with a test to make sure it works. Note you'll likely get a faster response at least from me) if you include a test or two for your changes.
   
   Thanks! will consider fort the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-proton] astitcher commented on pull request #388: NO-JIRA: [Python] Allow configuration of container ID

Posted by "astitcher (via GitHub)" <gi...@apache.org>.
astitcher commented on PR #388:
URL: https://github.com/apache/qpid-proton/pull/388#issuecomment-1497829984

   @Jmennius I've merged a neater version of this change with a test to make sure it works. Note you'll likely get a faster response at least from me) if you include a test or two for your changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-proton] asfgit closed pull request #388: NO-JIRA: [Python] Allow configuration of container ID

Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #388: NO-JIRA: [Python] Allow configuration of container ID
URL: https://github.com/apache/qpid-proton/pull/388


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org