You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jeremy Thomerson (JIRA)" <ji...@apache.org> on 2010/10/13 07:48:33 UTC
[jira] Created: (WICKET-3104) add feature to feedbackpanel to
automatically add itself to ajax requests
add feature to feedbackpanel to automatically add itself to ajax requests
-------------------------------------------------------------------------
Key: WICKET-3104
URL: https://issues.apache.org/jira/browse/WICKET-3104
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.5-M2.1, 1.5-M1
Reporter: Jeremy Thomerson
Assignee: Jeremy Thomerson
Priority: Trivial
Fix For: 1.5-M3
It would be nice to be able to tell a FeedbackPanel that you want it to automatically add itself to AJAX requests when a feedback message is added to any component, and it would accept the feedback message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3104) add feature to feedbackpanel to
automatically add itself to ajax requests
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920650#action_12920650 ]
Igor Vaynberg commented on WICKET-3104:
---------------------------------------
i think it is better to send AjaxRequest event, and let the feedback panel listen to it and add itself if it is not empty.
but. i think we should wait for 1.5.1. i would like to get 1.5 cleaned up and out of the door without adding more stuff to it.
> add feature to feedbackpanel to automatically add itself to ajax requests
> -------------------------------------------------------------------------
>
> Key: WICKET-3104
> URL: https://issues.apache.org/jira/browse/WICKET-3104
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5-M1, 1.5-M2.1
> Reporter: Jeremy Thomerson
> Assignee: Jeremy Thomerson
> Priority: Trivial
> Fix For: 1.5-M3
>
> Attachments: WICKET-3104.patch
>
>
> It would be nice to be able to tell a FeedbackPanel that you want it to automatically add itself to AJAX requests when a feedback message is added to any component, and it would accept the feedback message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3104) add feature to feedbackpanel to
automatically add itself to ajax requests
Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920652#action_12920652 ]
Jeremy Thomerson commented on WICKET-3104:
------------------------------------------
Can you determine "not empty" at that point? For some reason, I was thinking the hasMessages() method only returned accurate information after rendering began.... I'll have to look through it.
> add feature to feedbackpanel to automatically add itself to ajax requests
> -------------------------------------------------------------------------
>
> Key: WICKET-3104
> URL: https://issues.apache.org/jira/browse/WICKET-3104
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5-M1, 1.5-M2.1
> Reporter: Jeremy Thomerson
> Assignee: Jeremy Thomerson
> Priority: Trivial
> Attachments: WICKET-3104.patch
>
>
> It would be nice to be able to tell a FeedbackPanel that you want it to automatically add itself to AJAX requests when a feedback message is added to any component, and it would accept the feedback message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3104) add feature to feedbackpanel to
automatically add itself to ajax requests
Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Thomerson updated WICKET-3104:
-------------------------------------
Attachment: WICKET-3104.patch
This patch accomplishes what I was looking for, although it would be nice to expand it as mentioned in the TODO.
Not committing at this moment because it breaks innerFeedbackTest, which I'll have to look at another day.
> add feature to feedbackpanel to automatically add itself to ajax requests
> -------------------------------------------------------------------------
>
> Key: WICKET-3104
> URL: https://issues.apache.org/jira/browse/WICKET-3104
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5-M1, 1.5-M2.1
> Reporter: Jeremy Thomerson
> Assignee: Jeremy Thomerson
> Priority: Trivial
> Fix For: 1.5-M3
>
> Attachments: WICKET-3104.patch
>
>
> It would be nice to be able to tell a FeedbackPanel that you want it to automatically add itself to AJAX requests when a feedback message is added to any component, and it would accept the feedback message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3104) add feature to feedbackpanel to
automatically add itself to ajax requests
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-3104:
----------------------------------
Fix Version/s: (was: 1.5-M3)
> add feature to feedbackpanel to automatically add itself to ajax requests
> -------------------------------------------------------------------------
>
> Key: WICKET-3104
> URL: https://issues.apache.org/jira/browse/WICKET-3104
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5-M1, 1.5-M2.1
> Reporter: Jeremy Thomerson
> Assignee: Jeremy Thomerson
> Priority: Trivial
> Attachments: WICKET-3104.patch
>
>
> It would be nice to be able to tell a FeedbackPanel that you want it to automatically add itself to AJAX requests when a feedback message is added to any component, and it would accept the feedback message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.