You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@tomcat.apache.org by George Stanchev <Gs...@serena.com> on 2017/12/07 20:48:53 UTC
building TC 8.5 with checkstyle
I am trying to build TC 8.5.24 from source and running into checkstyle validation issues [1]. I looked at https://tomcat.apache.org/tomcat-8.5-doc/building.html and couldn't find anything that suggest that the default target would not build, neither checkstyle is mentioned. It is not a problem, because i can turn off the checkstyle validation can be turned off in a custome build.properties with "execute.validate=false" but I was wondering if the TC devs would like to at least mention it on the build instructions page OR fix the checkstyle issues....
George
[1]
validate:
[mkdir] Created dir: D:\work\My Projects\java\Tomcat\8.5.24-src\output\res\checkstyle
[checkstyle] Running Checkstyle 6.17 on 3211 files
[checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\LICENSE.txt:2: Line does not match expected header line of '^(rem)?\W*Licensed to the Apache Software Foundation \(ASF\) under one or mo
re$'. [RegexpHeader]
[checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\NOTICE.txt:1: Missing a header - not enough lines in file. [RegexpHeader]
[checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\apidocs\index-all.html:125: Line matches the illegal pattern '\s+$'. [RegexpSingleline]
[checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\apidocs\org\apache\commons\daemon\Daemon.html:200: Line matches the illegal pattern '\s+$'. [RegexpSingleline]
[checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\apidocs\org\apache\commons\daemon\DaemonInitException.html:114: Line matches the illegal pattern '\s+$'. [RegexpSingleline]
[checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\apidocs\org\apache\commons\daemon\package-summary.html:142: Line matches the illegal pattern '\s+$'. [RegexpSingleline]
[checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\apidocs\org\apache\commons\daemon\package-use.html:110: Line matches the illegal pattern '\s+$'. [RegexpSingleline]
[checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\apidocs\org\apache\commons\daemon\support\DaemonWrapper.html:247: Line matches the illegal pattern '\s+$'. [RegexpSingleline]
BUILD FAILED
RE: building TC 8.5 with checkstyle
Posted by George Stanchev <Gs...@serena.com>.
>On 07/12/17 21:12, Mark Thomas wrote:
>> On 07/12/17 20:48, George Stanchev wrote:
>>> I am trying to build TC 8.5.24 from source and running into checkstyle validation issues [1]. I looked at https://tomcat.apache.org/tomcat-8.5-doc/building.html and couldn't find anything that suggest that the default target would not build, neither checkstyle is mentioned. It is not a problem, because i can turn off the checkstyle validation can be turned off in a custome build.properties with "execute.validate=false" but I was wondering if the TC devs would like to at least mention it on the build instructions page OR fix the checkstyle issues....
>>
>> https://svn.apache.org/viewvc?view=revision&revision=1816748
> Also, don't configure base.path to be part of the source tree else Checkstyle will try to validate any 3rd party source the build downloads with the not unsurprising result that it fails validation.
Thanks Mark!
I definitely had my base path pointing to under the source tree since I wanted everything to be self-contained in the src dir. I will rework it a bit now...
Regards,
George
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org
Re: building TC 8.5 with checkstyle
Posted by Mark Thomas <ma...@apache.org>.
On 07/12/17 21:12, Mark Thomas wrote:
> On 07/12/17 20:48, George Stanchev wrote:
>> I am trying to build TC 8.5.24 from source and running into checkstyle validation issues [1]. I looked at https://tomcat.apache.org/tomcat-8.5-doc/building.html and couldn't find anything that suggest that the default target would not build, neither checkstyle is mentioned. It is not a problem, because i can turn off the checkstyle validation can be turned off in a custome build.properties with "execute.validate=false" but I was wondering if the TC devs would like to at least mention it on the build instructions page OR fix the checkstyle issues....
>
> https://svn.apache.org/viewvc?view=revision&revision=1816748
Also, don't configure base.path to be part of the source tree else
Checkstyle will try to validate any 3rd party source the build downloads
with the not unsurprising result that it fails validation.
Mark
>
> Mark
>
>
>>
>> George
>>
>>
>> [1]
>>
>> validate:
>> [mkdir] Created dir: D:\work\My Projects\java\Tomcat\8.5.24-src\output\res\checkstyle
>> [checkstyle] Running Checkstyle 6.17 on 3211 files
>> [checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\LICENSE.txt:2: Line does not match expected header line of '^(rem)?\W*Licensed to the Apache Software Foundation \(ASF\) under one or mo
>> re$'. [RegexpHeader]
>> [checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\NOTICE.txt:1: Missing a header - not enough lines in file. [RegexpHeader]
>> [checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\apidocs\index-all.html:125: Line matches the illegal pattern '\s+$'. [RegexpSingleline]
>> [checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\apidocs\org\apache\commons\daemon\Daemon.html:200: Line matches the illegal pattern '\s+$'. [RegexpSingleline]
>> [checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\apidocs\org\apache\commons\daemon\DaemonInitException.html:114: Line matches the illegal pattern '\s+$'. [RegexpSingleline]
>> [checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\apidocs\org\apache\commons\daemon\package-summary.html:142: Line matches the illegal pattern '\s+$'. [RegexpSingleline]
>> [checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\apidocs\org\apache\commons\daemon\package-use.html:110: Line matches the illegal pattern '\s+$'. [RegexpSingleline]
>> [checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\apidocs\org\apache\commons\daemon\support\DaemonWrapper.html:247: Line matches the illegal pattern '\s+$'. [RegexpSingleline]
>>
>> BUILD FAILED
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: users-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org
Re: building TC 8.5 with checkstyle
Posted by Mark Thomas <ma...@apache.org>.
On 07/12/17 20:48, George Stanchev wrote:
> I am trying to build TC 8.5.24 from source and running into checkstyle validation issues [1]. I looked at https://tomcat.apache.org/tomcat-8.5-doc/building.html and couldn't find anything that suggest that the default target would not build, neither checkstyle is mentioned. It is not a problem, because i can turn off the checkstyle validation can be turned off in a custome build.properties with "execute.validate=false" but I was wondering if the TC devs would like to at least mention it on the build instructions page OR fix the checkstyle issues....
https://svn.apache.org/viewvc?view=revision&revision=1816748
Mark
>
> George
>
>
> [1]
>
> validate:
> [mkdir] Created dir: D:\work\My Projects\java\Tomcat\8.5.24-src\output\res\checkstyle
> [checkstyle] Running Checkstyle 6.17 on 3211 files
> [checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\LICENSE.txt:2: Line does not match expected header line of '^(rem)?\W*Licensed to the Apache Software Foundation \(ASF\) under one or mo
> re$'. [RegexpHeader]
> [checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\NOTICE.txt:1: Missing a header - not enough lines in file. [RegexpHeader]
> [checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\apidocs\index-all.html:125: Line matches the illegal pattern '\s+$'. [RegexpSingleline]
> [checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\apidocs\org\apache\commons\daemon\Daemon.html:200: Line matches the illegal pattern '\s+$'. [RegexpSingleline]
> [checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\apidocs\org\apache\commons\daemon\DaemonInitException.html:114: Line matches the illegal pattern '\s+$'. [RegexpSingleline]
> [checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\apidocs\org\apache\commons\daemon\package-summary.html:142: Line matches the illegal pattern '\s+$'. [RegexpSingleline]
> [checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\apidocs\org\apache\commons\daemon\package-use.html:110: Line matches the illegal pattern '\s+$'. [RegexpSingleline]
> [checkstyle] [ERROR] D:\work\My Projects\java\Tomcat\8.5.24-src\libraries-download\commons-daemon-1.1.0\apidocs\org\apache\commons\daemon\support\DaemonWrapper.html:247: Line matches the illegal pattern '\s+$'. [RegexpSingleline]
>
> BUILD FAILED
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org