You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2019/01/21 23:34:56 UTC

[GitHub] nwangtw commented on a change in pull request #3163: Add target to generate packages for heron simulator

nwangtw commented on a change in pull request #3163: Add target to generate packages for heron simulator
URL: https://github.com/apache/incubator-heron/pull/3163#discussion_r249603040
 
 

 ##########
 File path: heron/simulator/src/java/BUILD
 ##########
 @@ -17,3 +17,28 @@ java_library(
     srcs = glob(["**/*.java"]),
     deps = simulator_deps_files,
 )
+
+java_binary(
+    name = "simulator-unshaded",
+    srcs = glob(["org/apache/heron/simulator/**/*.java"]),
+    deps = simulator_deps_files + [
+        "//third_party/java:kryo-neverlink",
+        "@org_apache_commons_commons_lang3//jar"
 
 Review comment:
   It is the version used in the project. I am ok to update the whole project but here it should be consistent to other BUILD files I think.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services