You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/03/20 23:38:29 UTC

Review Request: Fixed launcher to flush std::cout when copying local resource.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10054/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Ben Mahler.


Description
-------

Also fixed some other logging messages.


Diffs
-----

  src/launcher/launcher.cpp 3da41243cdcb45e0632f945b58773eeb7a81f668 
  src/slave/cgroups_isolator.cpp c06baecac5a89886673a36d3dad934e06a577875 
  src/slave/process_isolator.cpp e719a0711157f37cf87b92127fd4f50287b1cf21 
  src/slave/state.cpp 7d376d68089153de9622084659a4d4813e0e106e 

Diff: https://reviews.apache.org/r/10054/diff/


Testing
-------

make check


Thanks,

Vinod Kone

Re: Review Request: Fixed launcher to flush std::cout when copying local resource.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10054/#review18190
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On March 20, 2013, 11:40 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10054/
> -----------------------------------------------------------
> 
> (Updated March 20, 2013, 11:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> Also fixed some other logging messages.
> 
> 
> Diffs
> -----
> 
>   src/launcher/launcher.cpp 3da41243cdcb45e0632f945b58773eeb7a81f668 
>   src/slave/cgroups_isolator.cpp 0d9610145d35fac0c48f2ff65ede77f670557ac0 
>   src/slave/process_isolator.cpp 4b1b1c4fc2e3271cdcd9c1edfac91ea985ca6f05 
>   src/slave/state.cpp 7d376d68089153de9622084659a4d4813e0e106e 
> 
> Diff: https://reviews.apache.org/r/10054/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request: Fixed launcher to flush std::cout when copying local resource.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10054/
-----------------------------------------------------------

(Updated March 20, 2013, 11:40 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

benh's and proper rebase.


Description
-------

Also fixed some other logging messages.


Diffs (updated)
-----

  src/launcher/launcher.cpp 3da41243cdcb45e0632f945b58773eeb7a81f668 
  src/slave/cgroups_isolator.cpp 0d9610145d35fac0c48f2ff65ede77f670557ac0 
  src/slave/process_isolator.cpp 4b1b1c4fc2e3271cdcd9c1edfac91ea985ca6f05 
  src/slave/state.cpp 7d376d68089153de9622084659a4d4813e0e106e 

Diff: https://reviews.apache.org/r/10054/diff/


Testing
-------

make check


Thanks,

Vinod Kone

Re: Review Request: Fixed launcher to flush std::cout when copying local resource.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10054/#review18182
-----------------------------------------------------------



src/launcher/launcher.cpp
<https://reviews.apache.org/r/10054/#comment38377>

    s/ret/status/



src/launcher/launcher.cpp
<https://reviews.apache.org/r/10054/#comment38376>

    s/code/status/


- Benjamin Hindman


On March 20, 2013, 11 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10054/
> -----------------------------------------------------------
> 
> (Updated March 20, 2013, 11 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> Also fixed some other logging messages.
> 
> 
> Diffs
> -----
> 
>   src/launcher/launcher.cpp 3da41243cdcb45e0632f945b58773eeb7a81f668 
>   src/master/hierarchical_allocator_process.hpp 2422fbdc49fd575b615e73891e3cda6675358d2d 
>   src/master/master.cpp 5b0e8c03c516f9fc8bb729c21e876bdde89baf9c 
>   src/sched/sched.cpp a55329488ae886f76fdf4576050cdeb5ead8026b 
>   src/slave/cgroups_isolator.hpp 1732c4e9ea44eb3b4d6234898f28bf3a02df4a7e 
>   src/slave/cgroups_isolator.cpp 0d9610145d35fac0c48f2ff65ede77f670557ac0 
>   src/slave/constants.hpp ca1124afff9ef989c05723e314ea40555303a8ff 
>   src/slave/constants.cpp 6cd97f97659d68297829c67a7513a193214c9a4a 
>   src/slave/flags.hpp 95969aea57b3c02c905b33b00fbfa510590630cd 
>   src/slave/process_isolator.cpp 4b1b1c4fc2e3271cdcd9c1edfac91ea985ca6f05 
>   src/slave/slave.hpp 8d651faec7808fe6c6112a52cee963342c61c5bc 
>   src/slave/slave.cpp df06e30ed05e7faf9b2b30a91bcf7713d43c7fca 
>   src/slave/state.cpp 7d376d68089153de9622084659a4d4813e0e106e 
>   src/tests/master_tests.cpp 16f7637c144160448ca8f3eb50924be3a70d2c3d 
>   src/tests/slave_recovery_tests.cpp b9054b8238345193a2f24339a159f903f7624543 
>   third_party/libprocess/include/process/delay.hpp 44a5638fb8540cf67f6e586db4ed64c12129bf1c 
> 
> Diff: https://reviews.apache.org/r/10054/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request: Fixed launcher to flush std::cout when copying local resource.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10054/
-----------------------------------------------------------

(Updated March 20, 2013, 11 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

benm's


Description
-------

Also fixed some other logging messages.


Diffs (updated)
-----

  src/launcher/launcher.cpp 3da41243cdcb45e0632f945b58773eeb7a81f668 
  src/master/hierarchical_allocator_process.hpp 2422fbdc49fd575b615e73891e3cda6675358d2d 
  src/master/master.cpp 5b0e8c03c516f9fc8bb729c21e876bdde89baf9c 
  src/sched/sched.cpp a55329488ae886f76fdf4576050cdeb5ead8026b 
  src/slave/cgroups_isolator.hpp 1732c4e9ea44eb3b4d6234898f28bf3a02df4a7e 
  src/slave/cgroups_isolator.cpp 0d9610145d35fac0c48f2ff65ede77f670557ac0 
  src/slave/constants.hpp ca1124afff9ef989c05723e314ea40555303a8ff 
  src/slave/constants.cpp 6cd97f97659d68297829c67a7513a193214c9a4a 
  src/slave/flags.hpp 95969aea57b3c02c905b33b00fbfa510590630cd 
  src/slave/process_isolator.cpp 4b1b1c4fc2e3271cdcd9c1edfac91ea985ca6f05 
  src/slave/slave.hpp 8d651faec7808fe6c6112a52cee963342c61c5bc 
  src/slave/slave.cpp df06e30ed05e7faf9b2b30a91bcf7713d43c7fca 
  src/slave/state.cpp 7d376d68089153de9622084659a4d4813e0e106e 
  src/tests/master_tests.cpp 16f7637c144160448ca8f3eb50924be3a70d2c3d 
  src/tests/slave_recovery_tests.cpp b9054b8238345193a2f24339a159f903f7624543 
  third_party/libprocess/include/process/delay.hpp 44a5638fb8540cf67f6e586db4ed64c12129bf1c 

Diff: https://reviews.apache.org/r/10054/diff/


Testing
-------

make check


Thanks,

Vinod Kone

Re: Review Request: Fixed launcher to flush std::cout when copying local resource.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10054/#review18180
-----------------------------------------------------------

Ship it!



src/launcher/launcher.cpp
<https://reviews.apache.org/r/10054/#comment38372>

    quote the directory?



src/launcher/launcher.cpp
<https://reviews.apache.org/r/10054/#comment38373>

    quote?



src/launcher/launcher.cpp
<https://reviews.apache.org/r/10054/#comment38374>

    quote?



src/slave/state.cpp
<https://reviews.apache.org/r/10054/#comment38371>

    quote path?


- Ben Mahler


On March 20, 2013, 10:38 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10054/
> -----------------------------------------------------------
> 
> (Updated March 20, 2013, 10:38 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> Also fixed some other logging messages.
> 
> 
> Diffs
> -----
> 
>   src/launcher/launcher.cpp 3da41243cdcb45e0632f945b58773eeb7a81f668 
>   src/slave/cgroups_isolator.cpp c06baecac5a89886673a36d3dad934e06a577875 
>   src/slave/process_isolator.cpp e719a0711157f37cf87b92127fd4f50287b1cf21 
>   src/slave/state.cpp 7d376d68089153de9622084659a4d4813e0e106e 
> 
> Diff: https://reviews.apache.org/r/10054/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>