You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by dp...@apache.org on 2022/05/10 20:26:31 UTC

[superset] branch master updated: feat: deprecate /superset/testconn and migrate to api v1 (#20002)

This is an automated email from the ASF dual-hosted git repository.

dpgaspar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 7b7de9592b feat: deprecate /superset/testconn and migrate to api v1 (#20002)
7b7de9592b is described below

commit 7b7de9592b1852e1582f5be84e4d954e3f55f011
Author: Zef Lin <ze...@preset.io>
AuthorDate: Tue May 10 13:26:25 2022 -0700

    feat: deprecate /superset/testconn and migrate to api v1 (#20002)
    
    * feat: deprecate /superset/testconn and migrate to api v1
    
    * bring back core_tests
---
 superset/templates/superset/models/database/macros.html | 2 +-
 superset/views/core.py                                  | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/superset/templates/superset/models/database/macros.html b/superset/templates/superset/models/database/macros.html
index ae67e4b78f..f1d07220ef 100644
--- a/superset/templates/superset/models/database/macros.html
+++ b/superset/templates/superset/models/database/macros.html
@@ -22,7 +22,7 @@
       .append('<button id="testconn" class="btn btn-sm btn-primary">{{ _("Test Connection") }}</button>');
     $("#testconn").click(function(e) {
       e.preventDefault();
-      var url = "/superset/testconn";
+      var url = "/api/v1/database/test_connection";
       var csrf_token = "{{ csrf_token() if csrf_token else '' }}";
 
       $.ajaxSetup({
diff --git a/superset/views/core.py b/superset/views/core.py
index de3d4cb2ea..9ced8b485f 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -1333,6 +1333,11 @@ class Superset(BaseSupersetView):  # pylint: disable=too-many-public-methods
     @expose("/testconn", methods=["POST", "GET"])
     def testconn(self) -> FlaskResponse:  # pylint: disable=no-self-use
         """Tests a sqla connection"""
+        logger.warning(
+            "%s.testconn "
+            "This API endpoint is deprecated and will be removed in version 3.0.0",
+            self.__class__.__name__,
+        )
         db_name = request.json.get("name")
         uri = request.json.get("uri")
         try: