You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2019/01/20 11:22:28 UTC

[GitHub] nizhikov commented on issue #5598: IGNITE-10314 Spark dataframe will get wrong schema if user executes add/drop column DDL

nizhikov commented on issue #5598: IGNITE-10314 Spark dataframe will get wrong schema if user executes add/drop column DDL
URL: https://github.com/apache/ignite/pull/5598#issuecomment-455857821
 
 
   Hello, @ldzhjn 
   
   Sorry for the pause in review.
   
   Looks good to me! I think this PR is ready to be merged.
   
   I left some very minor comments regarding to the code formatting.
   Please, fix them before merge.
   
   Also, please, make sure you use spaces instead of table for indenting.
   
   package.scala#sqlCacheName
   package.scala#isValidSchema.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services