You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@asterixdb.apache.org by GitBox <gi...@apache.org> on 2021/05/01 21:47:46 UTC
[GitHub] [asterixdb] alindl opened a new pull request #15: Set proper inner dependency
alindl opened a new pull request #15:
URL: https://github.com/apache/asterixdb/pull/15
Setting this dependency, allows maven to do parallel builds, obviously improving building times.
`asterix-doc` needs at least one file (`SQLPP.HTML`) that is build by `asterix-lang-sqlpp`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [asterixdb] alindl commented on pull request #15: Set proper inner dependency
Posted by GitBox <gi...@apache.org>.
alindl commented on pull request #15:
URL: https://github.com/apache/asterixdb/pull/15#issuecomment-863531604
I just figured that there's an error because `asterix-doc` just plainly copies stuff from `asterix-lang-sqlpp`. It's even noted [here](https://github.com/apache/asterixdb/blob/5120106e9b776b70b7bed018074da4795581f012/asterixdb/asterix-doc/pom.xml#L87), so that comment tipped me off, that maybe we need to build `asterix-lang-sqlpp` before we can copy something from there 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [asterixdb] alindl commented on a change in pull request #15: Set proper inner dependency
Posted by GitBox <gi...@apache.org>.
alindl commented on a change in pull request #15:
URL: https://github.com/apache/asterixdb/pull/15#discussion_r653903681
##########
File path: asterixdb/asterix-doc/pom.xml
##########
@@ -45,6 +45,13 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-antrun-plugin</artifactId>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.asterix</groupId>
+ <artifactId>asterix-lang-sqlpp</artifactId>
+ <version>0.9.6-SNAPSHOT</version>
Review comment:
I'm actually not sure how you do that, I've never really worked with Maven before, but do you mean like that?
```suggestion
<version>${parent.version}</version>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [asterixdb] parshimers commented on pull request #15: Set proper inner dependency
Posted by GitBox <gi...@apache.org>.
parshimers commented on pull request #15:
URL: https://github.com/apache/asterixdb/pull/15#issuecomment-860115226
Wow! This is great, Thank you.
I tried to get this to work a long time ago, but I guess I was barking up the wrong tree. I thought it was because the javacc-maven-plugin didn't properly support parallel maven execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [asterixdb] parshimers commented on a change in pull request #15: Set proper inner dependency
Posted by GitBox <gi...@apache.org>.
parshimers commented on a change in pull request #15:
URL: https://github.com/apache/asterixdb/pull/15#discussion_r650439226
##########
File path: asterixdb/asterix-doc/pom.xml
##########
@@ -45,6 +45,13 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-antrun-plugin</artifactId>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.asterix</groupId>
+ <artifactId>asterix-lang-sqlpp</artifactId>
+ <version>0.9.6-SNAPSHOT</version>
Review comment:
can this be ${parent.version} ? We always keep this module's versison the same as the parent's. If it's like this it would complicate the version increment process during releases.
##########
File path: asterixdb/asterix-doc/pom.xml
##########
@@ -45,6 +45,13 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-antrun-plugin</artifactId>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.asterix</groupId>
+ <artifactId>asterix-lang-sqlpp</artifactId>
+ <version>0.9.6-SNAPSHOT</version>
Review comment:
and by "this" I mean <version>, sorry. I thought that comment would get inserted right at line 52.
##########
File path: asterixdb/asterix-doc/pom.xml
##########
@@ -45,6 +45,13 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-antrun-plugin</artifactId>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.asterix</groupId>
+ <artifactId>asterix-lang-sqlpp</artifactId>
+ <version>0.9.6-SNAPSHOT</version>
Review comment:
and by "this" I mean \<version\>, sorry. I thought that comment would get inserted right at line 52.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org