You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/11/07 02:23:23 UTC
[GitHub] [iceberg] KnightChess opened a new pull request #3487: iceberg: Icon for JetBrains Toolbox
KnightChess opened a new pull request #3487:
URL: https://github.com/apache/iceberg/pull/3487
#3478 I don't query how to generate multiple submission, maybe modified Commit order, so I close it and create a new pr
> Add icon for JetBrains Toolbox/Idea
>
> In tool Box: 
>
> In idea projects: 
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3487: iceberg: Icon for JetBrains Toolbox
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3487:
URL: https://github.com/apache/iceberg/pull/3487#issuecomment-963303005
I agree with @pan3793. The .gitignore change shouldn't be necessary. I'm also not sure that we need to be adding customization for a particular IDE to the project. It would be great to hear what other people think about this. FYI @jackye1995, @RussellSpitzer, @kbendick, @openinx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] KnightChess commented on pull request #3487: iceberg: Icon for JetBrains Toolbox
Posted by GitBox <gi...@apache.org>.
KnightChess commented on pull request #3487:
URL: https://github.com/apache/iceberg/pull/3487#issuecomment-962738018
> This doesn't appear to add an icon for JetBrains as it says in the description. Looks like this only adds the icon file to .gitignore. Can you clarify that this is what you intend to do?
Yeah，add the `icon.png` to `.idea` folder and modify `.gitignore` file to exclude it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on pull request #3487: iceberg: Icon for JetBrains Toolbox
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #3487:
URL: https://github.com/apache/iceberg/pull/3487#issuecomment-972121512
I like the icon, but I don't want to get into an Apache fight for including binary files in the release. I know sometimes this tends to rub certain folks the wrong way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] KnightChess commented on pull request #3487: iceberg: Icon for JetBrains Toolbox
Posted by GitBox <gi...@apache.org>.
KnightChess commented on pull request #3487:
URL: https://github.com/apache/iceberg/pull/3487#issuecomment-971120089
So it's better support doc for developer to decide personal development environment.
this issue will close next day, let's discuss in #3485
thanks for @rdblue @jackye1995 @pan3793 advice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3487: iceberg: Icon for JetBrains Toolbox
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3487:
URL: https://github.com/apache/iceberg/pull/3487#issuecomment-962659394
This doesn't appear to add an icon for JetBrains as it says in the description. Looks like this only adds the icon file to .gitignore. Can you clarify that this is what you intend to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 commented on a change in pull request #3487: iceberg: Icon for JetBrains Toolbox
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #3487:
URL: https://github.com/apache/iceberg/pull/3487#discussion_r744420086
##########
File path: .gitignore
##########
@@ -4,7 +4,9 @@
tmp/
# intellij files
-.idea
+.idea/*
+# Icon for JetBrains Toolbox
+!/.idea/icon.png
Review comment:
The change is unnecessary, we can always use `git add -f [file]` to force let git track the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] KnightChess closed pull request #3487: iceberg: Icon for JetBrains Toolbox
Posted by GitBox <gi...@apache.org>.
KnightChess closed pull request #3487:
URL: https://github.com/apache/iceberg/pull/3487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] KnightChess edited a comment on pull request #3487: iceberg: Icon for JetBrains Toolbox
Posted by GitBox <gi...@apache.org>.
KnightChess edited a comment on pull request #3487:
URL: https://github.com/apache/iceberg/pull/3487#issuecomment-971120089
So it's better support doc for developer to decide personal development environment.
this pr will close next day, let's discuss in #3485
thanks for @rdblue @jackye1995 @pan3793 advice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #3487: iceberg: Icon for JetBrains Toolbox
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #3487:
URL: https://github.com/apache/iceberg/pull/3487#issuecomment-963410861
I think I am borderline here, the argument for these features is that we already have `.baseline/idea` and `.baseline/eclipse`, which are IDE specific stuffs, and they can improve the developer experience. But I can also see that these customizations are opinionated, maybe some "nice" features are not desirable for some other people.
From my personal experience, my team also defined some Intellij run configurations for people to use to simplify testing and published in a repo, and people kept changing those to fit their own need. So we ended up just showing all the configurations in a wiki, and people can pick whatever they want. The `.idea` folder is ignored anyway, so it does not impact anyone else. I think this might be another way we can follow here to have Intellij configurations as a part of the developer guide (#3485).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org