You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by ustcweizhou <gi...@git.apache.org> on 2016/12/22 09:45:12 UTC
[GitHub] cloudstack pull request #1856: CLOUDSTACK-9569: propagate global configurati...
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1856
CLOUDSTACK-9569: propagate global configuration router.aggregation.command.each.timeout to KVM agent
The router.aggregation.command.each.timeout in global configuration is only applied on new created KVM host.
For existing KVM host, changing the value will not be effective.
We need to propagate the configuration to existing host when cloudstack-agent is connected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ustcweizhou/cloudstack set-kvm-host-params
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1856.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1856
----
commit ec5ab8dc196227bc728d5667090aa98fe8baf651
Author: Wei Zhou <w....@tech.leaseweb.com>
Date: 2016-12-22T09:14:36Z
CLOUDSTACK-9569: propagate global configuration router.aggregation.command.each.timeout to KVM agent
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1856: [4.9] CLOUDSTACK-9569: propagate global configuratio...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1856
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1856: [4.9] CLOUDSTACK-9569: propagate global configuratio...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1856
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1856: [4.9] CLOUDSTACK-9569: propagate global configuratio...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1856
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-501
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1856: [4.9] CLOUDSTACK-9569: propagate global configuratio...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1856
@karuturi this is ready for merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1856: [4.9] CLOUDSTACK-9569: propagate global configuratio...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1856
<b>Trillian test result (tid-845)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27608 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1856-t845-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Test completed. 47 look ok, 1 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 355.97 | test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 160.01 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 66.80 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 250.78 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 277.18 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 543.39 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 516.00 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1413.48 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 564.36 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 756.17 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1301.11 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.54 | test_volumes.py
test_08_resize_volume | Success | 156.44 | test_volumes.py
test_07_resize_fail | Success | 161.48 | test_volumes.py
test_06_download_detached_volume | Success | 156.37 | test_volumes.py
test_05_detach_volume | Success | 155.78 | test_volumes.py
test_04_delete_attached_volume | Success | 151.29 | test_volumes.py
test_03_download_attached_volume | Success | 156.33 | test_volumes.py
test_02_attach_volume | Success | 90.50 | test_volumes.py
test_01_create_volume | Success | 711.16 | test_volumes.py
test_deploy_vm_multiple | Success | 267.77 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.04 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.73 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.19 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 40.95 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.15 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.89 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.89 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.19 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.31 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 75.75 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 5.16 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.17 | test_templates.py
test_01_create_template | Success | 85.75 | test_templates.py
test_10_destroy_cpvm | Success | 161.72 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.64 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.61 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.58 | test_ssvm.py
test_06_stop_cpvm | Success | 131.85 | test_ssvm.py
test_05_stop_ssvm | Success | 163.97 | test_ssvm.py
test_04_cpvm_internals | Success | 1.20 | test_ssvm.py
test_03_ssvm_internals | Success | 3.43 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.60 | test_snapshots.py
test_04_change_offering_small | Success | 239.90 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.09 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.11 | test_service_offerings.py
test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.19 | test_secondary_storage.py
test_09_reboot_router | Success | 35.33 | test_routers.py
test_08_start_router | Success | 30.29 | test_routers.py
test_07_stop_router | Success | 10.16 | test_routers.py
test_06_router_advanced | Success | 0.06 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.70 | test_routers.py
test_03_restart_network_cleanup | Success | 65.56 | test_routers.py
test_02_router_internal_adv | Success | 1.09 | test_routers.py
test_01_router_internal_basic | Success | 0.57 | test_routers.py
test_router_dns_guestipquery | Success | 76.75 | test_router_dns.py
test_router_dns_externalipquery | Success | 0.05 | test_router_dns.py
test_router_dhcphosts | Success | 277.82 | test_router_dhcphosts.py
test_router_dhcp_opts | Success | 21.71 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 5.12 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 146.04 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.04 | test_regions.py
test_create_pvlan_network | Success | 5.23 | test_pvlan.py
test_dedicatePublicIpRange | Success | 0.42 | test_public_ip_range.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 515.96 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | Success | 344.85 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 87.25 | test_privategw_acl.py
test_01_primary_storage_nfs | Success | 35.79 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 15.21 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 15.44 | test_portable_publicip.py
test_isolate_network_password_server | Success | 89.43 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.13 | test_over_provisioning.py
test_oobm_zchange_password | Success | 35.78 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | Success | 16.33 | test_outofbandmanagement.py
test_oobm_issue_power_status | Success | 10.25 | test_outofbandmanagement.py
test_oobm_issue_power_soft | Success | 15.49 | test_outofbandmanagement.py
test_oobm_issue_power_reset | Success | 15.34 | test_outofbandmanagement.py
test_oobm_issue_power_on | Success | 15.31 | test_outofbandmanagement.py
test_oobm_issue_power_off | Success | 15.33 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | Success | 15.31 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | Success | 92.60 | test_outofbandmanagement.py
test_oobm_enable_feature_valid | Success | 5.15 | test_outofbandmanagement.py
test_oobm_enable_feature_invalid | Success | 0.10 | test_outofbandmanagement.py
test_oobm_disable_feature_valid | Success | 0.17 | test_outofbandmanagement.py
test_oobm_disable_feature_invalid | Success | 0.12 | test_outofbandmanagement.py
test_oobm_configure_invalid_driver | Success | 0.10 | test_outofbandmanagement.py
test_oobm_configure_default_driver | Success | 0.08 | test_outofbandmanagement.py
test_oobm_background_powerstate_sync | Success | 23.43 | test_outofbandmanagement.py
test_extendPhysicalNetworkVlan | Success | 15.32 | test_non_contigiousvlan.py
test_01_nic | Success | 424.23 | test_nic.py
test_releaseIP | Success | 258.00 | test_network.py
test_reboot_router | Success | 413.62 | test_network.py
test_public_ip_user_account | Success | 10.26 | test_network.py
test_public_ip_admin_account | Success | 40.27 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 66.90 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.71 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 124.36 | test_network.py
test_delete_account | Success | 287.80 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 55.67 | test_network.py
test_01_port_fwd_on_src_nat | Success | 111.74 | test_network.py
test_nic_secondaryip_add_remove | Success | 208.16 | test_multipleips_per_nic.py
login_test_saml_user | Success | 19.17 | test_login.py
test_assign_and_removal_lb | Success | 133.51 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 187.25 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 207.74 | test_loadbalance.py
test_03_list_snapshots | Success | 0.06 | test_list_ids_parameter.py
test_02_list_templates | Success | 0.04 | test_list_ids_parameter.py
test_01_list_volumes | Success | 0.03 | test_list_ids_parameter.py
test_07_list_default_iso | Success | 0.06 | test_iso.py
test_05_iso_permissions | Success | 0.09 | test_iso.py
test_04_extract_Iso | Success | 5.18 | test_iso.py
test_03_delete_iso | Success | 95.19 | test_iso.py
test_02_edit_iso | Success | 0.08 | test_iso.py
test_01_create_iso | Success | 21.00 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 203.95 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 148.31 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 522.45 | test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 430.15 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 10.36 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.32 | test_global_settings.py
test_rolepermission_lifecycle_update | Success | 6.20 | test_dynamicroles.py
test_rolepermission_lifecycle_list | Success | 5.99 | test_dynamicroles.py
test_rolepermission_lifecycle_delete | Success | 5.86 | test_dynamicroles.py
test_rolepermission_lifecycle_create | Success | 5.89 | test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates | Success | 5.99 | test_dynamicroles.py
test_role_lifecycle_update_role_inuse | Success | 5.91 | test_dynamicroles.py
test_role_lifecycle_update | Success | 11.18 | test_dynamicroles.py
test_role_lifecycle_list | Success | 5.91 | test_dynamicroles.py
test_role_lifecycle_delete | Success | 11.07 | test_dynamicroles.py
test_role_lifecycle_create | Success | 5.91 | test_dynamicroles.py
test_role_inuse_deletion | Success | 5.86 | test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers | Success | 8.26 | test_dynamicroles.py
test_role_account_acls | Success | 8.23 | test_dynamicroles.py
test_default_role_deletion | Success | 5.97 | test_dynamicroles.py
test_04_create_fat_type_disk_offering | Success | 0.07 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.04 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.06 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.08 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.11 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 20.61 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 35.69 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 50.61 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 10.38 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 60.80 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 5.97 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 5.98 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 223.13 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 212.45 | test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup | Success | 65.94 | test_affinity_groups.py
test_03_delete_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
test_01_create_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_06_copy_template | Skipped | 0.00 | test_templates.py
test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_deploy_vgpu_enabled_vm | Skipped | 0.00 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1856: CLOUDSTACK-9569: propagate global configurati...
Posted by murali-reddy <gi...@git.apache.org>.
Github user murali-reddy commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1856#discussion_r93599467
--- Diff: core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java ---
@@ -259,8 +260,18 @@ private Answer execute(GetDomRVersionCmd cmd) {
return new GetDomRVersionAnswer(cmd, result.getDetails(), lines[0], lines[1]);
}
+ public boolean configureHostParams(final Map<String, String> params) {
+ if (_params.get("router.aggregation.command.each.timeout") == null) {
--- End diff --
Why do we need this check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1856: CLOUDSTACK-9569: propagate global configuration rout...
Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1856
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1856: CLOUDSTACK-9569: propagate global configuration rout...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1856
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-415
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1856: CLOUDSTACK-9569: propagate global configurati...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1856#discussion_r93604300
--- Diff: core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java ---
@@ -259,8 +260,18 @@ private Answer execute(GetDomRVersionCmd cmd) {
return new GetDomRVersionAnswer(cmd, result.getDetails(), lines[0], lines[1]);
}
+ public boolean configureHostParams(final Map<String, String> params) {
+ if (_params.get("router.aggregation.command.each.timeout") == null) {
--- End diff --
the idea is: if router.aggregation.command.each.timeout is already set in agent.properties, then ignore the propagation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1856: CLOUDSTACK-9569: propagate global configurati...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1856#discussion_r93606574
--- Diff: core/src/com/cloud/agent/api/SetHostParamsCommand.java ---
@@ -0,0 +1,43 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.agent.api;
+
+import java.util.Map;
+
+public class SetHostParamsCommand extends Command {
+
+ Map<String, String> params;
--- End diff --
@koushik-das luckily there is no issue on our platforms. We have some similar definitions in other Command in cloudstack actually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1856: [4.9] CLOUDSTACK-9569: propagate global configuratio...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1856
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1856: CLOUDSTACK-9569: propagate global configuration rout...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1856
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1856: CLOUDSTACK-9569: propagate global configuration rout...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1856
rebase with apache/4.9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1856: CLOUDSTACK-9569: propagate global configuration rout...
Posted by murali-reddy <gi...@git.apache.org>.
Github user murali-reddy commented on the issue:
https://github.com/apache/cloudstack/pull/1856
@ustcweizhou this will be useful for 4.9 as well, would you mind rebasing the patch to 4.9?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1856: CLOUDSTACK-9569: propagate global configurati...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1856#discussion_r93603576
--- Diff: core/src/com/cloud/agent/api/SetHostParamsCommand.java ---
@@ -0,0 +1,43 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.agent.api;
+
+import java.util.Map;
+
+public class SetHostParamsCommand extends Command {
+
+ Map<String, String> params;
--- End diff --
Map is not serializable, also HashMap that is actually used may have issues with serialization. Please check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1856: CLOUDSTACK-9569: propagate global configuration rout...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1856
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1856: [4.9] CLOUDSTACK-9569: propagate global configuratio...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1856
LGTM.
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1856: [4.9] CLOUDSTACK-9569: propagate global confi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1856
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1856: CLOUDSTACK-9569: propagate global configuration rout...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1856
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-420
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1856: CLOUDSTACK-9569: propagate global configuration rout...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1856
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---