[jira] [Resolved] (SSHD-1152) Some warnings are never logged

["Guillaume Nodet (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SSHD-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guillaume Nodet resolved SSHD-1152.
-----------------------------------
    Fix Version/s: 2.6.1
       Resolution: Fixed

Thx, I've fixed it with https://github.com/apache/mina-sshd/commit/ea57983ca77717f22170db40b3048e005719e4fd

> Some warnings are never logged
> ------------------------------
>
>                 Key: SSHD-1152
>                 URL: https://issues.apache.org/jira/browse/SSHD-1152
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Achim Hügen
>            Assignee: Guillaume Nodet
>            Priority: Major
>             Fix For: 2.6.1
>
>
> Some Warnings that are output via a certain warn method in LoggingUtils don't make it into the log files.
> Example: ServerUserAuthService#handleUserAuthRequestMessage
> {code}
>         } catch (Exception e) {
>             warn("handleUserAuthRequestMessage({}) Failed ({}) to authenticate using factory method={}: {}",
>                     session, e.getClass().getSimpleName(), method, e.getMessage(), e);
>         }
> {code}
> There is a bug in the implementation that checks for "log.isDebugEnabled()" in all cases:
> {code}
>     public static void warn(Logger log, String message, Object o1, Object o2, Object o3, Object o4, Throwable t) {
>         if (log.isDebugEnabled() && t != null) {
>             log.warn(message, o1, o2, o3, o4, t);
>         } else if (log.isDebugEnabled()) {
>             log.warn(message, o1, o2, o3, o4);
>         }
>     }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org