You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/10/15 06:58:41 UTC
[GitHub] [geode-native] albertogpz opened a new pull request #676: Feature/geode 8613
albertogpz opened a new pull request #676:
URL: https://github.com/apache/geode-native/pull/676
This PR removes the exclusive access to the creation/closing of pool connections that uses the mutex that is also used to grant exclusive access to the ConnectionQueue.
That way access to the connection queue is not impaired when there are problems creating connections.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] albertogpz commented on pull request #676: GEODE-8613: Removing exclusive access to creation/closing of pool connections
Posted by GitBox <gi...@apache.org>.
albertogpz commented on pull request #676:
URL: https://github.com/apache/geode-native/pull/676#issuecomment-709806312
> I need more time to review this for correctness. I think the locking is required here to both protect concurrent updates to the `m_poolSize` value in various places as well as synchronize the CPU caches of this member.
Wouldn't that already be guaranteed given that the type of `m_poolSize` is `std::atomic<int32_t>`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on pull request #676: GEODE-8613: Removing exclusive access to creation/closing of pool connections
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on pull request #676:
URL: https://github.com/apache/geode-native/pull/676#issuecomment-710089765
> > I need more time to review this for correctness. I think the locking is required here to both protect concurrent updates to the `m_poolSize` value in various places as well as synchronize the CPU caches of this member.
>
> Wouldn't that already be guaranteed given that the type of `m_poolSize` is `std::atomic<int32_t>`?
I hadn't looked into the type yet but mostly yes that should be safe. Though if the pool and count are mutated independently there could be some issues with a mismatch. I will poke into this later today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mkevo merged pull request #676: GEODE-8613: Removing exclusive access to creation/closing of pool connections
Posted by GitBox <gi...@apache.org>.
mkevo merged pull request #676:
URL: https://github.com/apache/geode-native/pull/676
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org