You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by GitBox <gi...@apache.org> on 2022/11/25 10:23:28 UTC
[GitHub] [mesos] yasiribmcon opened a new pull request, #450: Upgrade GRPC to 1.11.1
yasiribmcon opened a new pull request, #450:
URL: https://github.com/apache/mesos/pull/450
Upgraded grpc from 1.10.0 to **1.11.1** as the newer version has support for s390x(big-endian) machines.
Changes have also been migrated from grpc-1.10.0.patch to grpc-1.11.1.patch.
grpc 1.11.1 tar.gz has been created using below commands:
**_git clone -b v1.11.1 https://github.com/grpc/grpc.git grpc-1.11.1
cd grpc-1.11.1/
git submodule update --init third_party/cares
cd ..
tar zcf grpc-1.11.1.tar.gz --exclude .git grpc-1.11.1_**
We have run **mesos-build.sh**(which is also used by Mesos CI) and its passing for below configuration :
**_BUILDTOOL=(cmake / autotools)
COMPILER=gcc
CONFIGURATION="--verbose --disable-libtool-wrappers --disable-parallel-test-execution"
ENVIRONMENT="GLOG_v=1 MESOS_VERBOSE=1 MESOS_TEST_AWAIT_TIMEOUT=60secs"_**
Only one test case _DockerFetcherPluginTest.INTERNET_CURL_FetchBlob_ is failing for both intel(amd64) and s390x as its referring to a private registry registry-1.docker.io, so this test case should pass when it gets run from Mesos CI.
CI logs(Intel/S390X) : [CI_Logs.zip](https://github.com/apache/mesos/files/10091041/CI_Logs.zip)
Note : We will remove GRPC changes from PR : https://github.com/apache/mesos/pull/449 and will resume work on it after this PR is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] cf-natali commented on pull request #450: Upgrade GRPC to 1.11.1
Posted by GitBox <gi...@apache.org>.
cf-natali commented on PR #450:
URL: https://github.com/apache/mesos/pull/450#issuecomment-1328286060
Tested in my environment as well, merged.
Thanks for your contribution, looking forward to the rest!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] cf-natali commented on pull request #450: Upgrade GRPC to 1.11.1
Posted by GitBox <gi...@apache.org>.
cf-natali commented on PR #450:
URL: https://github.com/apache/mesos/pull/450#issuecomment-1328307949
Ah, this caused the mesos-tidy build to fail: https://ci-builds.apache.org/job/Mesos/job/Mesos-Tidybot/CMAKE_ARGS=-DENABLE_LIBEVENT=OFF%20-DENABLE_SSL=OFF,label_exp=ubuntu/109/console
Looks like the GRPC version is hard-coded there: https://github.com/apache/mesos/blob/66d2f29946569b47a0a4d557de74a12c93f60457/support/mesos-tidy/entrypoint.sh#L46
I'll fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] cf-natali merged pull request #450: Upgrade GRPC to 1.11.1
Posted by GitBox <gi...@apache.org>.
cf-natali merged PR #450:
URL: https://github.com/apache/mesos/pull/450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org