You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Marcel Reutegger (JIRA)" <ji...@apache.org> on 2015/04/07 22:21:13 UTC
[jira] [Updated] (OAK-2418) int overflow with orderby causing huge
slowdown
[ https://issues.apache.org/jira/browse/OAK-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Reutegger updated OAK-2418:
----------------------------------
Fix Version/s: (was: 1.2)
> int overflow with orderby causing huge slowdown
> -----------------------------------------------
>
> Key: OAK-2418
> URL: https://issues.apache.org/jira/browse/OAK-2418
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Affects Versions: 1.0.9
> Reporter: Stefan Egli
> Assignee: Thomas Mueller
> Priority: Critical
> Fix For: 1.0.10, 1.1.6
>
> Attachments: oak-2418.patch
>
>
> Consider the following query:
> {code}
> //element(*,slingevent:Job) order by @slingevent:created ascending
> {code}
> this query - when running with a large number of slingevent:Job around - will take a very long time due to the fact, that FilterIterators.SortIterator.init() in the following loop:
> {code}
> if (list.size() > max * 2) {
> // remove tail entries right now, to save memory
> Collections.sort(list, orderBy);
> keepFirst(list, max);
> }
> {code}
> does a multiplication with 'max', which is by default set to Integer.MAX_VALUE (see FilterIterators.newCombinedFilter). This results in max *2 to overflow (result is -2) - thus that init-loop will sort the list for every additional entry. Which is definitely not the intention.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)