You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/17 16:22:04 UTC
[GitHub] [spark] Ngone51 opened a new pull request #27938:
[SPARK-31175][SQL] Avoid creating reverse comparator for each compare in
InterpretedOrdering
Ngone51 opened a new pull request #27938: [SPARK-31175][SQL] Avoid creating reverse comparator for each compare in InterpretedOrdering
URL: https://github.com/apache/spark/pull/27938
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Prpend `-` to the compare result instead of creating a new reverse comparator for each compare when sorting in DESC order in InterpretedOrdering.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Currently, we'll create a new reverse comparator for each compare in InterpretedOrdering, which could generate lots of small and instant object and hurt JVM when there're plenty of data.
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Pass Jenkins.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #27938: [SPARK-31175][SQL]
Avoid creating reverse comparator for each compare in InterpretedOrdering
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #27938: [SPARK-31175][SQL] Avoid creating reverse comparator for each compare in InterpretedOrdering
URL: https://github.com/apache/spark/pull/27938
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27938: [SPARK-31175][SQL] Avoid
creating reverse comparator for each compare in InterpretedOrdering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27938: [SPARK-31175][SQL] Avoid creating reverse comparator for each compare in InterpretedOrdering
URL: https://github.com/apache/spark/pull/27938#issuecomment-600306736
**[Test build #119939 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119939/testReport)** for PR 27938 at commit [`6f759b4`](https://github.com/apache/spark/commit/6f759b43db432946ba3dd8bc4254165939acd117).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27938:
[SPARK-31175][SQL] Avoid creating reverse comparator for each compare in
InterpretedOrdering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27938: [SPARK-31175][SQL] Avoid creating reverse comparator for each compare in InterpretedOrdering
URL: https://github.com/apache/spark/pull/27938#issuecomment-600307912
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on issue #27938: [SPARK-31175][SQL] Avoid
creating reverse comparator for each compare in InterpretedOrdering
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #27938: [SPARK-31175][SQL] Avoid creating reverse comparator for each compare in InterpretedOrdering
URL: https://github.com/apache/spark/pull/27938#issuecomment-600725247
thanks all!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on issue #27938: [SPARK-31175][SQL] Avoid
creating reverse comparator for each compare in InterpretedOrdering
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #27938: [SPARK-31175][SQL] Avoid creating reverse comparator for each compare in InterpretedOrdering
URL: https://github.com/apache/spark/pull/27938#issuecomment-600679178
ping @cloud-fan @HyukjinKwon Please take a look, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27938: [SPARK-31175][SQL]
Avoid creating reverse comparator for each compare in InterpretedOrdering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27938: [SPARK-31175][SQL] Avoid creating reverse comparator for each compare in InterpretedOrdering
URL: https://github.com/apache/spark/pull/27938#issuecomment-600168100
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24662/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27938: [SPARK-31175][SQL]
Avoid creating reverse comparator for each compare in InterpretedOrdering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27938: [SPARK-31175][SQL] Avoid creating reverse comparator for each compare in InterpretedOrdering
URL: https://github.com/apache/spark/pull/27938#issuecomment-600168092
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27938:
[SPARK-31175][SQL] Avoid creating reverse comparator for each compare in
InterpretedOrdering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27938: [SPARK-31175][SQL] Avoid creating reverse comparator for each compare in InterpretedOrdering
URL: https://github.com/apache/spark/pull/27938#issuecomment-600168092
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27938:
[SPARK-31175][SQL] Avoid creating reverse comparator for each compare in
InterpretedOrdering
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27938: [SPARK-31175][SQL] Avoid creating reverse comparator for each compare in InterpretedOrdering
URL: https://github.com/apache/spark/pull/27938#issuecomment-600167316
**[Test build #119939 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119939/testReport)** for PR 27938 at commit [`6f759b4`](https://github.com/apache/spark/commit/6f759b43db432946ba3dd8bc4254165939acd117).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27938: [SPARK-31175][SQL]
Avoid creating reverse comparator for each compare in InterpretedOrdering
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27938: [SPARK-31175][SQL] Avoid creating reverse comparator for each compare in InterpretedOrdering
URL: https://github.com/apache/spark/pull/27938#issuecomment-600713880
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27938: [SPARK-31175][SQL]
Avoid creating reverse comparator for each compare in InterpretedOrdering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27938: [SPARK-31175][SQL] Avoid creating reverse comparator for each compare in InterpretedOrdering
URL: https://github.com/apache/spark/pull/27938#issuecomment-600307926
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119939/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27938:
[SPARK-31175][SQL] Avoid creating reverse comparator for each compare in
InterpretedOrdering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27938: [SPARK-31175][SQL] Avoid creating reverse comparator for each compare in InterpretedOrdering
URL: https://github.com/apache/spark/pull/27938#issuecomment-600307926
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119939/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27938: [SPARK-31175][SQL]
Avoid creating reverse comparator for each compare in InterpretedOrdering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27938: [SPARK-31175][SQL] Avoid creating reverse comparator for each compare in InterpretedOrdering
URL: https://github.com/apache/spark/pull/27938#issuecomment-600307912
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27938:
[SPARK-31175][SQL] Avoid creating reverse comparator for each compare in
InterpretedOrdering
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27938: [SPARK-31175][SQL] Avoid creating reverse comparator for each compare in InterpretedOrdering
URL: https://github.com/apache/spark/pull/27938#issuecomment-600168100
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24662/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27938: [SPARK-31175][SQL] Avoid
creating reverse comparator for each compare in InterpretedOrdering
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27938: [SPARK-31175][SQL] Avoid creating reverse comparator for each compare in InterpretedOrdering
URL: https://github.com/apache/spark/pull/27938#issuecomment-600167316
**[Test build #119939 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119939/testReport)** for PR 27938 at commit [`6f759b4`](https://github.com/apache/spark/commit/6f759b43db432946ba3dd8bc4254165939acd117).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27938: [SPARK-31175][SQL]
Avoid creating reverse comparator for each compare in InterpretedOrdering
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27938: [SPARK-31175][SQL] Avoid creating reverse comparator for each compare in InterpretedOrdering
URL: https://github.com/apache/spark/pull/27938#issuecomment-600889319
+1, late LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org