You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "deki (via GitHub)" <gi...@apache.org> on 2023/04/12 07:02:06 UTC
[GitHub] [commons-fileupload] deki opened a new pull request, #213: Update pages to show latest release
deki opened a new pull request, #213:
URL: https://github.com/apache/commons-fileupload/pull/213
cherry-picked re-generated pages from 1.x rev. 29870448fb6bb7afd08503545543557224fa1310 to make sure people are using 1.5 release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] jochenw commented on pull request #213: Update pages to show latest release
Posted by "jochenw (via GitHub)" <gi...@apache.org>.
jochenw commented on PR #213:
URL: https://github.com/apache/commons-fileupload/pull/213#issuecomment-1505013477
Please, complete the changes by adding yourself as a contributor in the POM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] deki commented on pull request #213: Update pages to show latest release
Posted by "deki (via GitHub)" <gi...@apache.org>.
deki commented on PR #213:
URL: https://github.com/apache/commons-fileupload/pull/213#issuecomment-1505066100
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] codecov-commenter commented on pull request #213: Update pages to show latest release
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #213:
URL: https://github.com/apache/commons-fileupload/pull/213#issuecomment-1504770638
## [Codecov](https://codecov.io/gh/apache/commons-fileupload/pull/213?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#213](https://codecov.io/gh/apache/commons-fileupload/pull/213?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (502f505) into [master](https://codecov.io/gh/apache/commons-fileupload/commit/319557854e1e5e15454f9d114dfc8db97e8e1051?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3195578) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #213 +/- ##
=========================================
Coverage 74.50% 74.50%
Complexity 265 265
=========================================
Files 30 30
Lines 1051 1051
Branches 154 154
=========================================
Hits 783 783
Misses 200 200
Partials 68 68
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] deki closed pull request #213: Update pages to show latest release
Posted by "deki (via GitHub)" <gi...@apache.org>.
deki closed pull request #213: Update pages to show latest release
URL: https://github.com/apache/commons-fileupload/pull/213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] garydgregory commented on a diff in pull request #213: Update pages to show latest release
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #213:
URL: https://github.com/apache/commons-fileupload/pull/213#discussion_r1203988366
##########
README.md:
##########
@@ -79,7 +81,7 @@ There are some guidelines which will make applying PRs easier for us:
+ No tabs! Please use spaces for indentation.
+ Respect the code style.
+ Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted create a separate PR for this change.
-+ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn```.
++ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn clean test```.
Review Comment:
Also this page is generated at release time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] garydgregory commented on a diff in pull request #213: Update pages to show latest release
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #213:
URL: https://github.com/apache/commons-fileupload/pull/213#discussion_r1203986371
##########
README.md:
##########
@@ -79,7 +81,7 @@ There are some guidelines which will make applying PRs easier for us:
+ No tabs! Please use spaces for indentation.
+ Respect the code style.
+ Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted create a separate PR for this change.
-+ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn```.
++ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn clean test```.
Review Comment:
This is not correct, 'mvn' invokes the default maven goal which runs other checks as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] deki commented on a diff in pull request #213: Update pages to show latest release
Posted by "deki (via GitHub)" <gi...@apache.org>.
deki commented on code in PR #213:
URL: https://github.com/apache/commons-fileupload/pull/213#discussion_r1205006119
##########
README.md:
##########
@@ -79,7 +81,7 @@ There are some guidelines which will make applying PRs easier for us:
+ No tabs! Please use spaces for indentation.
+ Respect the code style.
+ Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted create a separate PR for this change.
-+ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn```.
++ Provide JUnit tests for your changes and make sure your changes don't break any existing tests by running ```mvn clean test```.
Review Comment:
I just merged the generated pages from the 1.x branch and obviously the related change is in there.
As you may be releasing 2.0 soon, we can also skip this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org