[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #160: [FLINK-28098] Refactor table store compactor

[GitBox <gi...@apache.org>]

JingsongLi commented on code in PR #160:
URL: https://github.com/apache/flink-table-store/pull/160#discussion_r899682102


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/table/sink/TableCompact.java:
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.store.table.sink;
+
+import org.apache.flink.connector.file.table.FileSystemConnectorOptions;
+import org.apache.flink.table.data.binary.BinaryRowData;
+import org.apache.flink.table.store.file.data.DataFileMeta;
+import org.apache.flink.table.store.file.mergetree.Increment;
+import org.apache.flink.table.store.file.mergetree.compact.CompactResult;
+import org.apache.flink.table.store.file.operation.FileStoreScan;
+import org.apache.flink.table.store.file.operation.FileStoreWrite;
+import org.apache.flink.table.store.file.predicate.PredicateConverter;
+import org.apache.flink.table.store.file.utils.FileStorePathFactory;
+import org.apache.flink.table.types.logical.RowType;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.function.BiPredicate;
+
+/** An abstraction layer above {@link FileStoreWrite#createCompactWriter} to provide compaction. */
+public class TableCompact {
+
+    private static final Logger LOG = LoggerFactory.getLogger(TableCompact.class);
+
+    private final FileStoreScan scan;
+    private final FileStoreWrite<?> write;
+    private final RowType partitionType;
+
+    private BiPredicate<BinaryRowData, Integer> partBucketFilter;
+
+    public TableCompact(FileStoreScan scan, FileStoreWrite<?> write, RowType partitionType) {
+        this.scan = scan;
+        this.write = write;
+        this.partitionType = partitionType;
+    }
+
+    public TableCompact withPartitions(Map<String, String> partitionSpec) {

Review Comment:
   `partitionSpec` can be partial, which means there can be many partitions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org