[jira] [Commented] (YARN-5719) Enforce a C standard for native container-executor

["Chris Douglas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563749#comment-15563749 ] 

Chris Douglas commented on YARN-5719:
-------------------------------------

There's a convenient [option|https://cmake.org/cmake/help/v3.1/prop_tgt/C_STANDARD.html] in recent versions of cmake to set the C standard in a portable way, but this is unavailable in the minimum version of cmake we require (2.6). v000 uses a set of switches based on a subset of [compiler ids|https://cmake.org/cmake/help/v3.0/variable/CMAKE_LANG_COMPILER_ID.html] we're likely(?) to support. The options themselves I pulled from cursory searches; I haven't tested with anything but gcc 4.8.4.

The LCE doesn't compile with ANSI C ({{-std=c89}}), but required almost no changes with C99. The only change with {{-pedantic-errors}} required some minor tweaks to {{get_user_info}}.

> Enforce a C standard for native container-executor
> --------------------------------------------------
>
>                 Key: YARN-5719
>                 URL: https://issues.apache.org/jira/browse/YARN-5719
>             Project: Hadoop YARN
>          Issue Type: Task
>          Components: nodemanager
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>         Attachments: YARN-5719.000.patch
>
>
> The {{container-executor}} build should declare the C standard it uses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org