You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/01/16 12:54:19 UTC

[GitHub] terrymanu commented on issue #1694: Refactor design of sharding transaction 2PC XA

terrymanu commented on issue #1694: Refactor design of sharding transaction 2PC XA 
URL: https://github.com/apache/incubator-shardingsphere/issues/1694#issuecomment-454768773
 
 
   Hi all,
       In current implementation for sharding-transaction-core, `ShardingTransactionManager` and `ShardingTransactionEngine` both define `begin`, `commit` & `rollback` method which are duplicated.
       We just remove `ShardingTransactionManager`, and let XA or Saga‘s provider to adapt it by themselves. For `XATransactionManager` , it doesn't need implements `ShardingTransactionManager`. Just care about `XAShardingTransactionEngine` is enough. We just add a new method to return `TransactionManager` from JTA is fine here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services