You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by kishorekasi <gi...@git.apache.org> on 2017/06/26 19:29:48 UTC
[GitHub] bookkeeper pull request #214: Fix ByteBuf refcount release
GitHub user kishorekasi opened a pull request:
https://github.com/apache/bookkeeper/pull/214
Fix ByteBuf refcount release
- Release ByteBuf in Replicator
- Do not release refcnt in PCBC upon addEntry error
- Remove unnecessary ByteBuf refcnt retain in Bookie protocol (V2) request encoding
Descriptions of the changes in this PR:
Addressing test failure - TestBackwardCompat.testCompat410 often fails due to io.netty.util.IllegalReferenceCountException (#198)
---
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`<Issue #>: Description of pull request`
`e.g. Issue 123: Description ...`
- [ ] Make sure tests pass via `mvn clean apache-rat:check install findbugs:check`.
- [ ] Replace `<Issue #>` in the title with the actual Issue number, if there is one.
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kishorekasi/bookkeeper testfailure
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/214.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #214
----
commit bd492f2548a464d0d874710f33770c5a74145017
Author: Kishore Kasi Udayashankar <ku...@salesforce.com>
Date: 2017-06-06T08:19:33Z
Fix ByteBuf refcount release
- Release ByteBuf in Replicator
- Do not release refcnt in PCBC upon addEntry error
- Remove unnecessary ByteBuf refcnt retain in Bookie protocol (V2) request encoding
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper pull request #214: Fix ByteBuf refcount release
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli closed the pull request at:
https://github.com/apache/bookkeeper/pull/214
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #214: Fix ByteBuf refcount release
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/214
@kishorekasi I am closing this PR as the fix as been committed by @sijie
Thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #214: Fix ByteBuf refcount release
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/214
@kishorekasi with this fix on Jenkins and on my laptop the build crashes during tests.
This never happens on actual master.
see https://builds.apache.org/job/bookkeeper-precommit-pullrequest/83/console
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project bookkeeper-server: ExecutionException The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[ERROR] Command was /bin/sh -c cd /home/jenkins/jenkins-slave/workspace/bookkeeper-precommit-pullrequest/bookkeeper-server && /usr/local/asfpackages/java/jdk1.8.0_131/jre/bin/java -Xmx2G -Djava.net.preferIPv4Stack=true -jar /home/jenkins/jenkins-slave/workspace/bookkeeper-precommit-pullrequest/bookkeeper-server/target/surefire/surefirebooter1899336251170950845.jar /home/jenkins/jenkins-slave/workspace/bookkeeper-precommit-pullrequest/bookkeeper-server/target/surefire/surefire6073010246191968653tmp /home/jenkins/jenkins-slave/workspace/bookkeeper-precommit-pullrequest/bookkeeper-server/target/surefire/surefire_382480740216379793999tmp
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #214: Fix ByteBuf refcount release
Posted by kishorekasi <gi...@git.apache.org>.
Github user kishorekasi commented on the issue:
https://github.com/apache/bookkeeper/pull/214
@eolivelli Please confirm if your branch is different than bookkeeper master. From the stack trace in Journal.run() there seems to be a line of code releasing ByteBuf. I don't see that in master code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #214: Fix ByteBuf refcount release
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/214
some errors from my logs:
org.apache.bookkeeper.test.TestBackwardCompat-output.txt:
```
io.netty.util.IllegalReferenceCountException: refCnt: 0, decrement: 1
at io.netty.buffer.AbstractReferenceCountedByteBuf.release0(AbstractReferenceCountedByteBuf.java:101)
at io.netty.buffer.AbstractReferenceCountedByteBuf.release(AbstractReferenceCountedByteBuf.java:89)
at io.netty.buffer.AbstractPooledDerivedByteBuf$PooledNonRetainedDuplicateByteBuf.release0(AbstractPooledDerivedByteBuf.java:192)
at io.netty.buffer.AbstractDerivedByteBuf.release(AbstractDerivedByteBuf.java:85)
at org.apache.bookkeeper.bookie.Journal.run(Journal.java:965)
```
org.apache.bookkeeper.client.BookieRecoveryTest-output.txt:
```
2017-06-27 11:10:04,114 - ERROR - [BookieJournal-15052:BookieCriticalThread@41] - Uncaught exception in thread BookieJournal-15052 and is exiting!
io.netty.util.IllegalReferenceCountException: refCnt: 0, decrement: 1
at io.netty.buffer.AbstractReferenceCountedByteBuf.release0(AbstractReferenceCountedByteBuf.java:101)
at io.netty.buffer.AbstractReferenceCountedByteBuf.release(AbstractReferenceCountedByteBuf.java:89)
at io.netty.buffer.AbstractPooledDerivedByteBuf$PooledNonRetainedDuplicateByteBuf.release0(AbstractPooledDerivedByteBuf.java:192)
at io.netty.buffer.AbstractDerivedByteBuf.release(AbstractDerivedByteBuf.java:85)
at org.apache.bookkeeper.bookie.Journal.run(Journal.java:965)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---