You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "John Ruiz (JIRA)" <ji...@apache.org> on 2011/03/18 19:42:30 UTC
[jira] Created: (THRIFT-1097) Do not fail silently when IDL
contains semi-colons instead of commas
Do not fail silently when IDL contains semi-colons instead of commas
--------------------------------------------------------------------
Key: THRIFT-1097
URL: https://issues.apache.org/jira/browse/THRIFT-1097
Project: Thrift
Issue Type: Improvement
Components: C# - Compiler
Affects Versions: 0.6
Environment: Windows 7 (x64) .NET 4.0
Reporter: John Ruiz
Priority: Minor
GIVEN
1. The following IDL file (Notification.thrift):
namespace my.example
struct Notification {
1: required string id;
2: optional string respondsTo;
3: required string topic;
4: required i64 created;
5: optional string type;
6: optional string body;
}
WHEN
1. thrift -v --gen csharp:log_unexpected,hashcode Notification.thrift
OBSERVED OUTCOME
I see the following in the console:
Scanning <path>/Notification.thrift for includes
Parsing <path>/Notification.thrift for types
Program: <path>/Notification.thrift
Generating "csharp:log_unexpected,hashcode"
a gen-csharp folder is generated, but is completely empty.
EXPECTED OUTCOME
The console should display a message stating that it failed to generate code because of a problem in the IDL.
REMARKS
When I saw my error and changed the semi-colons to commas, everything worked as expected.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1097) Do not fail silently when IDL
contains semi-colons instead of commas
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009258#comment-13009258 ]
Bryan Duxbury commented on THRIFT-1097:
---------------------------------------
This is confusing, because semicolons are not an error. I use semicolons to terminate my lines in my own Thrift files. I don't know why you are seeing this behavior. Is it constrained to only the C# compiler?
> Do not fail silently when IDL contains semi-colons instead of commas
> --------------------------------------------------------------------
>
> Key: THRIFT-1097
> URL: https://issues.apache.org/jira/browse/THRIFT-1097
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Compiler
> Affects Versions: 0.6
> Environment: Windows 7 (x64) .NET 4.0
> Reporter: John Ruiz
> Priority: Minor
> Labels: thrift
>
> GIVEN
> 1. The following IDL file (Notification.thrift):
> namespace my.example
> struct Notification {
> 1: required string id;
> 2: optional string respondsTo;
> 3: required string topic;
> 4: required i64 created;
> 5: optional string type;
> 6: optional string body;
> }
> WHEN
> 1. thrift -v --gen csharp:log_unexpected,hashcode Notification.thrift
> OBSERVED OUTCOME
> I see the following in the console:
> Scanning <path>/Notification.thrift for includes
> Parsing <path>/Notification.thrift for types
> Program: <path>/Notification.thrift
> Generating "csharp:log_unexpected,hashcode"
> a gen-csharp folder is generated, but is completely empty.
> EXPECTED OUTCOME
> The console should display a message stating that it failed to generate code because of a problem in the IDL.
> REMARKS
> When I saw my error and changed the semi-colons to commas, everything worked as expected.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira