You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by br...@apache.org on 2005/09/29 11:26:13 UTC

svn commit: r292409 - /maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/version/DefaultPluginVersionManager.java

Author: brett
Date: Thu Sep 29 02:26:07 2005
New Revision: 292409

URL: http://svn.apache.org/viewcvs?rev=292409&view=rev
Log:
PR: MNG-936
make sure directory exists first

Modified:
    maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/version/DefaultPluginVersionManager.java

Modified: maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/version/DefaultPluginVersionManager.java
URL: http://svn.apache.org/viewcvs/maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/version/DefaultPluginVersionManager.java?rev=292409&r1=292408&r2=292409&view=diff
==============================================================================
--- maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/version/DefaultPluginVersionManager.java (original)
+++ maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/version/DefaultPluginVersionManager.java Thu Sep 29 02:26:07 2005
@@ -582,6 +582,7 @@
 
             try
             {
+                pluginRegistryFile.getParentFile().mkdirs();
                 fWriter = new FileWriter( pluginRegistryFile );
 
                 PluginRegistryXpp3Writer writer = new PluginRegistryXpp3Writer();



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r292409 - /maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/version/DefaultPluginVersionManager.java

Posted by Trygve Laugstøl <tr...@codehaus.org>.
On Thu, 2005-09-29 at 09:26 +0000, brett@apache.org wrote:
> Author: brett
> Date: Thu Sep 29 02:26:07 2005
> New Revision: 292409
> 
> URL: http://svn.apache.org/viewcvs?rev=292409&view=rev
> Log:
> PR: MNG-936
> make sure directory exists first

[snip]

> +                pluginRegistryFile.getParentFile().mkdirs();
>                  fWriter = new FileWriter( pluginRegistryFile );
>  
>                  PluginRegistryXpp3Writer writer = new PluginRegistryXpp3Writer();
> 

You always have to check that the return value of mkdirs() is true to
make sure that the directories actually was created. Dumb, but that's
life :)

--
Trygve


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org