[GitHub] [tvm] junrushao commented on a diff in pull request #12866: [MetaSchedule][UX] User Interface for Jupyter Notebook

[GitBox <gi...@apache.org>]

junrushao commented on code in PR #12866:
URL: https://github.com/apache/tvm/pull/12866#discussion_r978868793


##########
src/meta_schedule/task_scheduler/gradient_based.cc:
##########
@@ -178,6 +201,7 @@ class GradientBasedNode final : public TaskSchedulerNode {
     }
     record.best_time_cost_history.push_back(best_time_cost);
     record.trials += results.size();
+    TVM_PY_LOG(CLEAR, this->logging_func);

Review Comment:
   we might want to decouple the `TVM_PY_LOG` macro with screen clearing, in case one might misuse for example:
   
   ```suggestion
       TVM_PY_LOG(CLEAR, this->logging_func) << "I'm expecting to print anything";
   ```



##########
src/meta_schedule/task_scheduler/gradient_based.cc:
##########
@@ -178,6 +201,7 @@ class GradientBasedNode final : public TaskSchedulerNode {
     }
     record.best_time_cost_history.push_back(best_time_cost);
     record.trials += results.size();
+    TVM_PY_LOG(CLEAR, this->logging_func);

Review Comment:
   we might want to decouple the `TVM_PY_LOG` macro with screen clearing, in case one might misuse for example:
   
   ```python
       TVM_PY_LOG(CLEAR, this->logging_func) << "I'm expecting to print anything";
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org