You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Jayapal Reddy <ja...@citrix.com> on 2013/05/14 10:20:36 UTC
Review Request: Deleting private gateways while deleting vpc in case
multiple private gateways
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11149/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Alena Prokharchyk.
Description
-------
Deleting private gateways while deleting vpc in case multiple private gateways
This addresses bug CLOUDSTACK-2441.
Diffs
-----
engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDao.java 8cb5c59
engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java b4d403e
server/src/com/cloud/network/vpc/VpcManager.java f3b4bbc
server/src/com/cloud/network/vpc/VpcManagerImpl.java fb3d41e
server/test/com/cloud/vpc/MockVpcManagerImpl.java 1e2cd5f
Diff: https://reviews.apache.org/r/11149/diff/
Testing
-------
1. Create vpc and created more than one private gateway in this vpc
2. Deleted vpc
3. observed that the all private gateways got deleted
Thanks,
Jayapal Reddy
Re: Review Request: Deleting private gateways while deleting vpc in case
multiple private gateways
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11149/#review20531
-----------------------------------------------------------
Ship it!
Commit c94c71b4ce25bc12a2505547a8fdd79fa574fae3
- Kishan Kavala
On May 14, 2013, 9:34 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11149/
> -----------------------------------------------------------
>
> (Updated May 14, 2013, 9:34 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Alena Prokharchyk.
>
>
> Description
> -------
>
> Deleting private gateways while deleting vpc in case multiple private gateways
>
>
> This addresses bug CLOUDSTACK-2441.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDao.java 8cb5c59
> engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java b4d403e
> server/src/com/cloud/network/vpc/VpcManager.java f3b4bbc
> server/src/com/cloud/network/vpc/VpcManagerImpl.java fb3d41e
> server/test/com/cloud/vpc/MockVpcManagerImpl.java 1e2cd5f
>
> Diff: https://reviews.apache.org/r/11149/diff/
>
>
> Testing
> -------
>
> 1. Create vpc and created more than one private gateway in this vpc
> 2. Deleted vpc
> 3. observed that the all private gateways got deleted
>
>
> Thanks,
>
> Jayapal Reddy
>
>
Re: Review Request: Deleting private gateways while deleting vpc in case
multiple private gateways
Posted by Jayapal Reddy <ja...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11149/
-----------------------------------------------------------
(Updated May 14, 2013, 9:34 a.m.)
Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Alena Prokharchyk.
Changes
-------
updated listByVpcIdAndType method
Description
-------
Deleting private gateways while deleting vpc in case multiple private gateways
This addresses bug CLOUDSTACK-2441.
Diffs (updated)
-----
engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDao.java 8cb5c59
engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java b4d403e
server/src/com/cloud/network/vpc/VpcManager.java f3b4bbc
server/src/com/cloud/network/vpc/VpcManagerImpl.java fb3d41e
server/test/com/cloud/vpc/MockVpcManagerImpl.java 1e2cd5f
Diff: https://reviews.apache.org/r/11149/diff/
Testing
-------
1. Create vpc and created more than one private gateway in this vpc
2. Deleted vpc
3. observed that the all private gateways got deleted
Thanks,
Jayapal Reddy