[jira] Commented: (THRIFT-409) Add "union" to Thrift

["David Reiss (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736738#action_12736738 ] 

David Reiss commented on THRIFT-409:
------------------------------------

You added some whitespace to a blank line at the end of the parser (.yy).  Also, I think a lot of the stuff you did under src/parse can be reverted since my version of the parser change just treats unions as structs with a special flag set.  I haven't looked at the Java-specific stuff yet.

> Add "union" to Thrift
> ---------------------
>
>                 Key: THRIFT-409
>                 URL: https://issues.apache.org/jira/browse/THRIFT-409
>             Project: Thrift
>          Issue Type: New Feature
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>             Fix For: 0.2
>
>         Attachments: one_rule.diff, thrift-409-v2.patch, thrift-409.patch
>
>
> It would be very helpful to have a "union" construct in Thrift. Let's decide on the design and then break up into sub-issues to add this feature.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.