You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/19 08:34:18 UTC
[GitHub] [arrow-datafusion] mustafasrepo opened a new issue, #4980: Return Vec instead of bool in ExecutionPlan::maintains_input_order
mustafasrepo opened a new issue, #4980:
URL: https://github.com/apache/arrow-datafusion/issues/4980
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
Currently API of `maintains_input_order` is as follows `fn maintains_input_order(&self) -> bool`. It returns a boolean indicating whether the executor keeps ordering. Although this is sufficient for most of the executors. For executors with multiple children, this API is insufficient. Consider `UnionExec` with two children where ordering of children are `Sort(a, b)` and `Sort(a)` respectively. The output will be sorted with `Sort(a)`. However, in current API we return `false`(Returning `true` would be wrong). However, if we were to update API to return `Vec<bool>`. We could return `vec![false, true]`. This will enable us to further optimize physical plans.
**Describe the solution you'd like**
N.A
**Describe alternatives you've considered**
N.A
**Additional context**
N.A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed issue #4980: Return Vec instead of bool in ExecutionPlan::maintains_input_order
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #4980: Return Vec<bool> instead of bool in ExecutionPlan::maintains_input_order
URL: https://github.com/apache/arrow-datafusion/issues/4980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org