You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Anoop Sam John (JIRA)" <ji...@apache.org> on 2014/08/01 08:28:38 UTC
[jira] [Commented] (HBASE-11628) Clean up tests that expect an
exception
[ https://issues.apache.org/jira/browse/HBASE-11628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14081975#comment-14081975 ]
Anoop Sam John commented on HBASE-11628:
----------------------------------------
In tests where we have some more test code after catch, we wont be able to do this
try{
...
fail()
}catch(Exception e) {
}
....
....
....
> Clean up tests that expect an exception
> ---------------------------------------
>
> Key: HBASE-11628
> URL: https://issues.apache.org/jira/browse/HBASE-11628
> Project: HBase
> Issue Type: Sub-task
> Components: test
> Reporter: Sean Busbey
> Priority: Trivial
> Labels: newbie
>
> We have a few tests that look for expected exceptions by manually catching and explicitly failing in case no exception happens.
> Places that need to be fixed can be found by running:
> {code}
> $> grep -rie "[^n]expected *exception" `find . -name test -path '*/src/*' -type d | xargs`
> {code}
> (there are some false positives, e.g. TestIPv6NIOServerSocketChannel)
> We should clean these up to use [JUnit's expected arg to the Test annotation|http://junit.org/javadoc/4.11/org/junit/Test.html#expected()].
--
This message was sent by Atlassian JIRA
(v6.2#6252)