You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "oscerd (via GitHub)" <gi...@apache.org> on 2026/07/27 17:46:39 UTC
[PR] CAMEL-24223: camel-jbang-mcp - Locale.ROOT cost formatting and model-specific disclaimer (follow-up) [camel]
oscerd opened a new pull request, #25167:
URL: https://github.com/apache/camel/pull/25167
### Motivation
Follow-up to [CAMEL-24223](https://issues.apache.org/jira/browse/CAMEL-24223) / #25052, which merged before these review refinements landed. Picks up the remaining points from that PR's review.
### Changes
- **`formatCost` now uses `Locale.ROOT`** for both branches. Previously `String.format("$%.6f", cost)` used the JVM default locale, so under a comma-decimal locale (e.g. French) the tool emitted `$0,003000` — MCP clients that parse these strings would break. This is the substantive fix.
- **Model-specific disclaimer.** The top-level disclaimer now states explicitly that token-based (LLM) components are priced as a *specific* model, not a provider-wide figure, and that Nova Lite / Haiku / local models (Ollama) cost far less, often ~zero — so the estimate is not misread as a real cost for those. Addresses davsclaus's concern about phantom costs for provider-agnostic components.
- **Tighter tests.** `shouldExtractSchemesCorrectly` now uses `containsExactlyInAnyOrder("file", "docling", "aws-bedrock", "aws2-s3")` (catches both a false `uri` capture and a dropped `file` scheme), and `shouldEstimateCostForAiPipeline` pins the breakdown to exactly 3 priced components and asserts the computed `aws-bedrock` per-execution cost rather than only the count.
### Testing
`RouteCostEstimateToolsTest` — 11 tests, all passing against current `main`.
Main-only (4.22.0), additive — no backport.
_Claude Code on behalf of Andrea Cosentino (@oscerd)._
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24223: camel-jbang-mcp - Locale.ROOT cost formatting and model-specific disclaimer (follow-up) [camel]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd merged PR #25167:
URL: https://github.com/apache/camel/pull/25167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24223: camel-jbang-mcp - Locale.ROOT cost formatting and model-specific disclaimer (follow-up) [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25167:
URL: https://github.com/apache/camel/pull/25167#issuecomment-5095409931
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24223: camel-jbang-mcp - Locale.ROOT cost formatting and model-specific disclaimer (follow-up) [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25167:
URL: https://github.com/apache/camel/pull/25167#issuecomment-5095540718
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `dsl/camel-jbang/camel-jbang-mcp`
---
<details><summary>:microscope: Scalpel shadow comparison — Scalpel: 1 tested, 0 compile-only — current: 1 all tested</summary>
[Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **1 affected modules** (current approach: 1).
**Skip-tests mode would test 1 modules** (1 direct + 0 downstream), **skip tests for 0** (generated code, meta-modules)
<details><summary>Modules Scalpel would test (1)</summary>
- `camel-jbang-mcp`
</details>
> :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
</details>
:warning: **Some tests are disabled on GitHub Actions** (`@DisabledIfSystemProperty(named = "ci.env.name")`) and require manual verification:
- `dsl/camel-jbang/camel-jbang-mcp`: 1 test(s) disabled on GitHub Actions
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/30290762152)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org