[jira] [Commented] (IGNITE-5040) ML examples

["Oleg Ignatenko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-5040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978123#comment-15978123 ] 

Oleg Ignatenko commented on IGNITE-5040:
----------------------------------------

(/) fix for {{TracerExample}} was pushed to branch ignite-5040.

Problem was in Java code not in JS.

The cause was that some invocations of {{String.format}} were with implicit locale (dependent on user's machine). At machines with particular locales this caused [decimal mark|https://en.wikipedia.org/wiki/Decimal_mark|what's this] to output as comma causing JSON parsing errors.

The fix was to explicitly set locale (US) that formats decimal mark as dot. With such a locale things were displayed correctly.

I also managed to use fixed code to reproduce that issue in code that runs at TracerExample, in order to make sure that behavior indeed depends on the locale. With French locale that uses comma for decimal mark my browser was showing same troublesome output as at bug reporter's machine.

> ML examples
> -----------
>
>                 Key: IGNITE-5040
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5040
>             Project: Ignite
>          Issue Type: Bug
>          Components: ml
>    Affects Versions: 2.0
>            Reporter: Sergey Kozlov
>            Assignee: Yury Babak
>             Fix For: 2.0
>
>
> I've reviewed examples for ML module and found some issues:
> 1. There's no description for examples at beginning of code (as we've for other java examples)
> 2. TracerExample opens the empty HTML page (seems JS error)
> 3. Example isn't a test and shouldn't have asserts. Correctness of example results is responsibility of tests.
> 4. Some local API calls used without running Ignite nodes would be better to provide as part of remote jobs sent to the cluster



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)