You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "westonpace (via GitHub)" <gi...@apache.org> on 2023/04/03 21:06:56 UTC
[GitHub] [arrow] westonpace opened a new pull request, #34870: GH-34869: [C++] Configure alpine linux nightly job to build gtest from source
westonpace opened a new pull request, #34870:
URL: https://github.com/apache/arrow/pull/34870
### Rationale for this change
The nightly test is currently failing with an error:
```
-- Found GTest: /usr/lib/cmake/GTest/GTestConfig.cmake (found suitable version "1.11.0", minimum required is "1.10.0")
CMake Error at cmake_modules/ThirdpartyToolchain.cmake:2236 (message):
System GTest is built with a C++ standard lower than 17. Use bundled GTest
via passing in CMake flag
-DGTest_SOURCE="BUNDLED"
```
### What changes are included in this PR?
Changes the alpine linux nightly test to use `-DGTest_SOURCE="BUNDLED"`
### Are these changes tested?
Yes, by the nightly test itself.
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34870: GH-34869: [C++] Configure alpine linux nightly job to build gtest from source
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34870:
URL: https://github.com/apache/arrow/pull/34870#discussion_r1156477756
##########
docker-compose.yml:
##########
@@ -223,6 +223,8 @@ services:
<<: *ccache
ARROW_ENABLE_TIMING_TESTS: # inherit
ARROW_MIMALLOC: "ON"
+ GTest_SOURCE: "BUNDLED" # Alpine's GTest is not built against
+ # C++17 so we build from source
Review Comment:
Could you move this to `ci/docker/alpine-linux-3.16-cpp.dockerfile` like other `*_SOURCE=BUNDLED`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34870: GH-34869: [C++] Configure alpine linux nightly job to build gtest from source
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34870:
URL: https://github.com/apache/arrow/pull/34870#issuecomment-1494980499
:warning: GitHub issue #34869 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a diff in pull request #34870: GH-34869: [C++] Configure alpine linux nightly job to build gtest from source
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on code in PR #34870:
URL: https://github.com/apache/arrow/pull/34870#discussion_r1156624390
##########
docker-compose.yml:
##########
@@ -223,6 +223,8 @@ services:
<<: *ccache
ARROW_ENABLE_TIMING_TESTS: # inherit
ARROW_MIMALLOC: "ON"
+ GTest_SOURCE: "BUNDLED" # Alpine's GTest is not built against
+ # C++17 so we build from source
Review Comment:
Good catch. I have done this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34870: GH-34869: [C++] Configure alpine linux nightly job to build gtest from source
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34870:
URL: https://github.com/apache/arrow/pull/34870#issuecomment-1494980443
* Closes: #34869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34870: GH-34869: [C++] Configure alpine linux nightly job to build gtest from source
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34870:
URL: https://github.com/apache/arrow/pull/34870#issuecomment-1498023545
Benchmark runs are scheduled for baseline = 379c1fb03a78c108846516987b3b2583ef650cb8 and contender = 3927a6f1da6c21e9aba5467d43891dc77d710387. 3927a6f1da6c21e9aba5467d43891dc77d710387 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/fea465d4273546abaa9088795c4024d8...dc4cf78ba29e46648e2fc37bdf213d17/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5cf7cc220ca7421f92656b291d5b3c47...eb8a76d4c0b844baafffbbc2279dbcc7/)
[Finished :arrow_down:0.26% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a77cf53c43614741923cd12ac653e5fb...8f9b492670ca40e09fefd09b1c2c5baf/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a92da209346a4f2f8a210c1b8d59ecff...2f29b890274a4bebb1831255d47288fb/)
Buildkite builds:
[Finished] [`3927a6f1` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2633)
[Failed] [`3927a6f1` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2665)
[Finished] [`3927a6f1` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2631)
[Failed] [`3927a6f1` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2656)
[Finished] [`379c1fb0` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2632)
[Failed] [`379c1fb0` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2664)
[Finished] [`379c1fb0` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2630)
[Failed] [`379c1fb0` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2655)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #34870: GH-34869: [C++] Configure alpine linux nightly job to build gtest from source
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on PR #34870:
URL: https://github.com/apache/arrow/pull/34870#issuecomment-1495218079
@github-actions crossbow submit test-alpine-linux-cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34870: GH-34869: [C++] Configure alpine linux nightly job to build gtest from source
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34870:
URL: https://github.com/apache/arrow/pull/34870#issuecomment-1494983443
Revision: 4b0869f49970543079867912be3baa3e60d2319f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-914e7e5a7e](https://github.com/ursacomputing/crossbow/branches/all?query=actions-914e7e5a7e)
|Task|Status|
|----|------|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4601341830/jobs/8129083743)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #34870: GH-34869: [C++] Configure alpine linux nightly job to build gtest from source
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #34870:
URL: https://github.com/apache/arrow/pull/34870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #34870: GH-34869: [C++] Configure alpine linux nightly job to build gtest from source
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on PR #34870:
URL: https://github.com/apache/arrow/pull/34870#issuecomment-1494980546
@github-actions crossbow submit test-alpine-linux-cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34870: GH-34869: [C++] Configure alpine linux nightly job to build gtest from source
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34870:
URL: https://github.com/apache/arrow/pull/34870#issuecomment-1495219432
Revision: 667fc105f3fc038db0beef518fa577f7660eaf03
Submitted crossbow builds: [ursacomputing/crossbow @ actions-5e6bf86d81](https://github.com/ursacomputing/crossbow/branches/all?query=actions-5e6bf86d81)
|Task|Status|
|----|------|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4603044252/jobs/8132670151)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org