You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/20 03:42:39 UTC
[GitHub] [airflow] blcksrx opened a new pull request #12498: Impala hook implention
blcksrx opened a new pull request #12498:
URL: https://github.com/apache/airflow/pull/12498
Impala hook implention
related: #8918
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #12498: Impala hook implention
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #12498:
URL: https://github.com/apache/airflow/pull/12498#issuecomment-732291035
Yes. See: https://github.com/apache/airflow/pull/12527
Can you do a rebase?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blcksrx commented on a change in pull request #12498: Impala hook implention
Posted by GitBox <gi...@apache.org>.
blcksrx commented on a change in pull request #12498:
URL: https://github.com/apache/airflow/pull/12498#discussion_r531399094
##########
File path: docs/apache-airflow-providers-apache-impala/index.rst
##########
@@ -0,0 +1,29 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+``apache-airflow-providers-apache-impala``
+=========================================
Review comment:
Thanks! there is another error related to spelling error.
```
#################### Spelling errors summary ####################
==================== apache-airflow-providers-apache-impala ====================
```
what about it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #12498: Impala hook implention
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #12498:
URL: https://github.com/apache/airflow/pull/12498#issuecomment-731424790
Building documentation for new providers is broken, but that's what I'm working on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12498: Impala hook implention
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12498:
URL: https://github.com/apache/airflow/pull/12498#issuecomment-731278878
[The Workflow run](https://github.com/apache/airflow/actions/runs/374761873) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12498: Impala hook implention
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12498:
URL: https://github.com/apache/airflow/pull/12498#issuecomment-731291246
[The Workflow run](https://github.com/apache/airflow/actions/runs/374810451) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12498: Impala hook implention
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12498:
URL: https://github.com/apache/airflow/pull/12498#issuecomment-732318731
[The Workflow run](https://github.com/apache/airflow/actions/runs/379462576) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blcksrx commented on a change in pull request #12498: Impala hook implention
Posted by GitBox <gi...@apache.org>.
blcksrx commented on a change in pull request #12498:
URL: https://github.com/apache/airflow/pull/12498#discussion_r531399094
##########
File path: docs/apache-airflow-providers-apache-impala/index.rst
##########
@@ -0,0 +1,29 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+``apache-airflow-providers-apache-impala``
+=========================================
Review comment:
Thanks! there is another error related to spelling error.
```
#################### Spelling errors summary ####################
==================== apache-airflow-providers-apache-impala ====================
```
what about it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blcksrx commented on pull request #12498: Impala hook implention
Posted by GitBox <gi...@apache.org>.
blcksrx commented on pull request #12498:
URL: https://github.com/apache/airflow/pull/12498#issuecomment-732257741
@mik-laj has the problem solved?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12498: Impala hook implention
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12498:
URL: https://github.com/apache/airflow/pull/12498#issuecomment-732316442
[The Workflow run](https://github.com/apache/airflow/actions/runs/379456551) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12498: Impala hook implention
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12498:
URL: https://github.com/apache/airflow/pull/12498#issuecomment-732316210
[The Workflow run](https://github.com/apache/airflow/actions/runs/379456105) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blcksrx commented on pull request #12498: Impala hook implention
Posted by GitBox <gi...@apache.org>.
blcksrx commented on pull request #12498:
URL: https://github.com/apache/airflow/pull/12498#issuecomment-734660100
@mik-laj can you help on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blcksrx closed pull request #12498: Impala hook implention
Posted by GitBox <gi...@apache.org>.
blcksrx closed pull request #12498:
URL: https://github.com/apache/airflow/pull/12498
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blcksrx commented on pull request #12498: Impala hook implention
Posted by GitBox <gi...@apache.org>.
blcksrx commented on pull request #12498:
URL: https://github.com/apache/airflow/pull/12498#issuecomment-732291734
Yes. I'm going to do it now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #12498: Impala hook implention
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #12498:
URL: https://github.com/apache/airflow/pull/12498#discussion_r527532631
##########
File path: airflow/providers/apache/impala/README.md
##########
@@ -0,0 +1,18 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ -->
+
+# Package apache-airflow-backport-providers-apache-impala
Review comment:
Can you add provider.yaml also?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12498: Impala hook implention
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12498:
URL: https://github.com/apache/airflow/pull/12498#issuecomment-731279508
[The Workflow run](https://github.com/apache/airflow/actions/runs/374770088) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blcksrx commented on a change in pull request #12498: Impala hook implention
Posted by GitBox <gi...@apache.org>.
blcksrx commented on a change in pull request #12498:
URL: https://github.com/apache/airflow/pull/12498#discussion_r527802882
##########
File path: airflow/providers/apache/impala/README.md
##########
@@ -0,0 +1,18 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ -->
+
+# Package apache-airflow-backport-providers-apache-impala
Review comment:
Yes. I did it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #12498: Impala hook implention
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #12498:
URL: https://github.com/apache/airflow/pull/12498#discussion_r527846445
##########
File path: airflow/providers/apache/impala/provider.yaml
##########
@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+---
+package-name: apache-airflow-providers-apache-impala
+description: |
Review comment:
```suggestion
package-name: apache-airflow-providers-apache-impala
name: Apache Impala
description: |
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #12498: Impala hook implention
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #12498:
URL: https://github.com/apache/airflow/pull/12498#discussion_r531397720
##########
File path: docs/apache-airflow-providers-apache-impala/index.rst
##########
@@ -0,0 +1,29 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+``apache-airflow-providers-apache-impala``
+=========================================
Review comment:
```suggestion
==========================================
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blcksrx commented on pull request #12498: Impala hook implention
Posted by GitBox <gi...@apache.org>.
blcksrx commented on pull request #12498:
URL: https://github.com/apache/airflow/pull/12498#issuecomment-731298184
@mik-laj I didn't get it. what's worng?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org