[GitHub] [netbeans] matthiasblaesing commented on pull request #4549: Initial ANTL v4 Grammar Support (Syntax Highlighting)

[GitBox <gi...@apache.org>]

matthiasblaesing commented on PR #4549:
URL: https://github.com/apache/netbeans/pull/4549#issuecomment-1236323065

   > @matthiasblaesing Please check the code generation and inclusion.
   
   Looks sane to me. For the generated file I thought about the right license. I know that the implementation here aligns with the way the CSS module is build, but maybe using the BSD-3-clause license would be better for the generated java files. They are directly derived from the grammar, so it seems that should match.
   
   If I see it correctly, the grammar is used mostly verbatim (only adding a license header), this is good and makes it easier updateable. If there would be more changes, we'd need to consider, whether or not we want to be able to update from upstream or really create a fork. But this is a discussion independent of this implementation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists