You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/06 21:34:47 UTC

[GitHub] [superset] rusackas commented on a change in pull request #17902: chore: Moves spec files to the src folder - iteration 10

rusackas commented on a change in pull request #17902:
URL: https://github.com/apache/superset/pull/17902#discussion_r779880344



##########
File path: superset-frontend/src/explore/components/ExploreAdditionalActionsMenu/ExploreAdditionalActionsMenu.test.jsx
##########
@@ -43,12 +48,15 @@ describe('ExploreAdditionalActionsMenu', () => {
     ).toBe(true);
   });
   it('renders a dropdown with 3 items', () => {
-    const wrapper = mount(<ExploreAdditionalActionsMenu {...defaultProps} />, {
-      wrappingComponent: ThemeProvider,
-      wrappingComponentProps: {
-        theme: supersetTheme,
+    const wrapper = mount(
+      <ExploreAdditionalActionsMenu store={store} {...defaultProps} />,
+      {
+        wrappingComponent: ThemeProvider,
+        wrappingComponentProps: {
+          theme: supersetTheme,
+        },

Review comment:
       Could use `styledMount` here and skip the `supersetTheme` / `ThemeProvider` bits, if we wanna do a little extra sweeping up.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org