You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2017/03/02 22:27:44 UTC
[kudu-CR] [flaky tests] Allow for the master to take longer to start
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6230
Change subject: [flaky tests] Allow for the master to take longer to start
......................................................................
[flaky tests] Allow for the master to take longer to start
With the additional work that the master has to perform for
security it's taking longer to boot, causing some tests to
timeout while waiting for the master to be ready.
Example from alter_schema_randomized-test:
I0302 03:22:13.666565 10295 catalog_manager.cc:850] Loading CA info into memory...
I0302 03:22:14.347914 10295 catalog_manager.cc:894] Loading token signing keys...
F0302 03:22:15.072451 20059 alter_table-randomized-test.cc:99] Check failed: _s.ok() Bad status: Timed out: Timed out after 30s waiting for master (127.0.0.1:46514) startup
This patch just doubles the time we allow the master to
take to boot up before we give up with a Status::TimedOut().
Change-Id: I1389361a3811b265178e3a174bf94af44d40fee9
---
M src/kudu/integration-tests/external_mini_cluster.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/6230/1
--
To view, visit http://gerrit.cloudera.org:8080/6230
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1389361a3811b265178e3a174bf94af44d40fee9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] [flaky tests] Allow for the master to take longer to start
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.
Change subject: [flaky tests] Allow for the master to take longer to start
......................................................................
[flaky tests] Allow for the master to take longer to start
With the additional work that the master has to perform for
security it's taking longer to boot, causing some tests to
timeout while waiting for the master to be ready.
Example from alter_schema_randomized-test:
I0302 03:22:13.666565 10295 catalog_manager.cc:850] Loading CA info into memory...
I0302 03:22:14.347914 10295 catalog_manager.cc:894] Loading token signing keys...
F0302 03:22:15.072451 20059 alter_table-randomized-test.cc:99] Check failed: _s.ok() Bad status: Timed out: Timed out after 30s waiting for master (127.0.0.1:46514) startup
This patch just doubles the time we allow the master to
take to boot up before we give up with a Status::TimedOut().
Change-Id: I1389361a3811b265178e3a174bf94af44d40fee9
Reviewed-on: http://gerrit.cloudera.org:8080/6230
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/external_mini_cluster.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6230
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1389361a3811b265178e3a174bf94af44d40fee9
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [flaky tests] Allow for the master to take longer to start
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [flaky tests] Allow for the master to take longer to start
......................................................................
Patch Set 1: Code-Review+2
lgtm, curious to know what's taking so long at boot, maybe we should add some more SCOPED_LOG_SLOW_EXECUTION in various spots, but this is also fine.
--
To view, visit http://gerrit.cloudera.org:8080/6230
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1389361a3811b265178e3a174bf94af44d40fee9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No