You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "Sjur N. Moshagen (JIRA)" <ji...@apache.org> on 2006/09/25 13:34:50 UTC
[jira] Created: (FOR-936) Forrest "looses" the locale when
switching pages
Forrest "looses" the locale when switching pages
------------------------------------------------
Key: FOR-936
URL: http://issues.apache.org/jira/browse/FOR-936
Project: Forrest
Issue Type: Bug
Components: Core operations, Internationalisation (i18n), Launch 'forrest run'
Affects Versions: 0.8-dev
Reporter: Sjur N. Moshagen
When moving from one page to another and switching locales in between, the chosen locale is lost when entering the new page. To reproduce:
1) set up and run forrest with i18n ON
2) open a localized page
3) switch locale by appending '?locale=XY' in the address field
4) open another page available in both the original locale (before the switch) and the new locale XY
5) notice how the new page is displayed in the original locale, NOT the expected XY locale
Although one could argue that the described behaviour is wanted in some cases, I believe that to most users it would be natural that the locale is "sticky" once changed - it should not change back by itself. Thus, the "sticky" behaviour should be default in Forrest.
The fix is simple, patch to come soon.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (FOR-936) Forrest "looses" the locale when switching
pages
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-936?page=all ]
David Crossley closed FOR-936.
------------------------------
Fix Version/s: 0.8-dev
Resolution: Fixed
Patch applied, thanks.
> Forrest "looses" the locale when switching pages
> ------------------------------------------------
>
> Key: FOR-936
> URL: http://issues.apache.org/jira/browse/FOR-936
> Project: Forrest
> Issue Type: Bug
> Components: Launch 'forrest run', Core operations, Internationalisation (i18n)
> Affects Versions: 0.8-dev
> Reporter: Sjur N. Moshagen
> Fix For: 0.8-dev
>
> Attachments: sticky-locale-patch.txt
>
>
> When moving from one page to another and switching locales in between, the chosen locale is lost when entering the new page. To reproduce:
> 1) set up and run forrest with i18n ON
> 2) open a localized page
> 3) switch locale by appending '?locale=XY' in the address field
> 4) open another page available in both the original locale (before the switch) and the new locale XY
> 5) notice how the new page is displayed in the original locale, NOT the expected XY locale
> Although one could argue that the described behaviour is wanted in some cases, I believe that to most users it would be natural that the locale is "sticky" once changed - it should not change back by itself. Thus, the "sticky" behaviour should be default in Forrest.
> The fix is simple, patch to come soon.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (FOR-936) Forrest "looses" the locale when
switching pages
Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thorsten Scherler updated FOR-936:
----------------------------------
Fix Version/s: (was: 0.8-dev)
0.9
I am not sure why this issue is on the 0.8 roadmap but since the CLI is gone in cocoon trunk the provided patch has to be tested against a cli replacement.
> Forrest "looses" the locale when switching pages
> ------------------------------------------------
>
> Key: FOR-936
> URL: https://issues.apache.org/jira/browse/FOR-936
> Project: Forrest
> Issue Type: Bug
> Components: Core operations, Internationalisation (i18n), Launch 'forrest run'
> Affects Versions: 0.8-dev
> Reporter: Sjur N. Moshagen
> Fix For: 0.9
>
> Attachments: sticky-locale-patch.txt
>
>
> When moving from one page to another and switching locales in between, the chosen locale is lost when entering the new page. To reproduce:
> 1) set up and run forrest with i18n ON
> 2) open a localized page
> 3) switch locale by appending '?locale=XY' in the address field
> 4) open another page available in both the original locale (before the switch) and the new locale XY
> 5) notice how the new page is displayed in the original locale, NOT the expected XY locale
> Although one could argue that the described behaviour is wanted in some cases, I believe that to most users it would be natural that the locale is "sticky" once changed - it should not change back by itself. Thus, the "sticky" behaviour should be default in Forrest.
> The fix is simple, patch to come soon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (FOR-936) Forrest "looses" the locale when
switching pages
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-936?page=all ]
David Crossley reopened FOR-936:
--------------------------------
Reopening because this doesn't work with Cocoon command-line. I reverted the patch.
See the forrestbot results:
http://thread.gmane.org/gmane.text.xml.forrest.devel/22557
... org.apache.cocoon.environment.commandline.CommandLineRequest.getLocales() method not yet implemented!
> Forrest "looses" the locale when switching pages
> ------------------------------------------------
>
> Key: FOR-936
> URL: http://issues.apache.org/jira/browse/FOR-936
> Project: Forrest
> Issue Type: Bug
> Components: Launch 'forrest run', Core operations, Internationalisation (i18n)
> Affects Versions: 0.8-dev
> Reporter: Sjur N. Moshagen
> Fix For: 0.8-dev
>
> Attachments: sticky-locale-patch.txt
>
>
> When moving from one page to another and switching locales in between, the chosen locale is lost when entering the new page. To reproduce:
> 1) set up and run forrest with i18n ON
> 2) open a localized page
> 3) switch locale by appending '?locale=XY' in the address field
> 4) open another page available in both the original locale (before the switch) and the new locale XY
> 5) notice how the new page is displayed in the original locale, NOT the expected XY locale
> Although one could argue that the described behaviour is wanted in some cases, I believe that to most users it would be natural that the locale is "sticky" once changed - it should not change back by itself. Thus, the "sticky" behaviour should be default in Forrest.
> The fix is simple, patch to come soon.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (FOR-936) Forrest "looses" the locale when
switching pages
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gavin updated FOR-936:
----------------------
Other Info: (was: [Patch available])
Remove 'Patch Available'
Patch was tested and reverted because it never worked. However it may be due to it being reliant on other issues submitted by Sjur at the time. It needs revisiting when a CLI replacement is available. Unless that is Sjur wants this working for 0.8 release in which case I'd like Sjur to look at it again.
> Forrest "looses" the locale when switching pages
> ------------------------------------------------
>
> Key: FOR-936
> URL: https://issues.apache.org/jira/browse/FOR-936
> Project: Forrest
> Issue Type: Bug
> Components: Core operations, Internationalisation (i18n), Launch 'forrest run'
> Affects Versions: 0.8-dev
> Reporter: Sjur N. Moshagen
> Fix For: 0.9
>
> Attachments: sticky-locale-patch.txt
>
>
> When moving from one page to another and switching locales in between, the chosen locale is lost when entering the new page. To reproduce:
> 1) set up and run forrest with i18n ON
> 2) open a localized page
> 3) switch locale by appending '?locale=XY' in the address field
> 4) open another page available in both the original locale (before the switch) and the new locale XY
> 5) notice how the new page is displayed in the original locale, NOT the expected XY locale
> Although one could argue that the described behaviour is wanted in some cases, I believe that to most users it would be natural that the locale is "sticky" once changed - it should not change back by itself. Thus, the "sticky" behaviour should be default in Forrest.
> The fix is simple, patch to come soon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FOR-936) Forrest "looses" the locale when
switching pages
Posted by "Tim Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Williams updated FOR-936:
-----------------------------
Fix Version/s: (was: 0.9-dev)
0.10
We need a release before we figure out what to do with the CLI, so moving this to the next release.
> Forrest "looses" the locale when switching pages
> ------------------------------------------------
>
> Key: FOR-936
> URL: https://issues.apache.org/jira/browse/FOR-936
> Project: Forrest
> Issue Type: Bug
> Components: Core operations, Internationalisation (i18n), Launch 'forrest run'
> Affects Versions: 0.8
> Reporter: Sjur N. Moshagen
> Fix For: 0.10
>
> Attachments: sticky-locale-patch.txt
>
>
> When moving from one page to another and switching locales in between, the chosen locale is lost when entering the new page. To reproduce:
> 1) set up and run forrest with i18n ON
> 2) open a localized page
> 3) switch locale by appending '?locale=XY' in the address field
> 4) open another page available in both the original locale (before the switch) and the new locale XY
> 5) notice how the new page is displayed in the original locale, NOT the expected XY locale
> Although one could argue that the described behaviour is wanted in some cases, I believe that to most users it would be natural that the locale is "sticky" once changed - it should not change back by itself. Thus, the "sticky" behaviour should be default in Forrest.
> The fix is simple, patch to come soon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FOR-936) Forrest "looses" the locale when
switching pages
Posted by "Sjur N. Moshagen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-936?page=all ]
Sjur N. Moshagen updated FOR-936:
---------------------------------
Attachment: sticky-locale-patch.txt
Attached is a patch that fixes the issue by changing some settings in the LocaleAction configuration in the root sitemap.
The patch also turns on locale negotiation in the LocaleMatcher.
> Forrest "looses" the locale when switching pages
> ------------------------------------------------
>
> Key: FOR-936
> URL: http://issues.apache.org/jira/browse/FOR-936
> Project: Forrest
> Issue Type: Bug
> Components: Core operations, Internationalisation (i18n), Launch 'forrest run'
> Affects Versions: 0.8-dev
> Reporter: Sjur N. Moshagen
> Attachments: sticky-locale-patch.txt
>
>
> When moving from one page to another and switching locales in between, the chosen locale is lost when entering the new page. To reproduce:
> 1) set up and run forrest with i18n ON
> 2) open a localized page
> 3) switch locale by appending '?locale=XY' in the address field
> 4) open another page available in both the original locale (before the switch) and the new locale XY
> 5) notice how the new page is displayed in the original locale, NOT the expected XY locale
> Although one could argue that the described behaviour is wanted in some cases, I believe that to most users it would be natural that the locale is "sticky" once changed - it should not change back by itself. Thus, the "sticky" behaviour should be default in Forrest.
> The fix is simple, patch to come soon.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira